Fixed Note tooltip: Button height inconsistency with icon+text and icon only buttons, in Firefox: shrinking note textarea

[marquisite]

Affected version

2.1.2

Here on XenForo.com, XFMG's note tooltip 'Save' and 'Cancel' buttons have additional padding whereas the delete button has normal padding.

The same button height/padding issue was previously fixed for XFMG image editor buttons:

Fixed - Edit image page: Button height inconsistency with icon+text and icon only buttons

The XFMG edit image page under XF2.1/FA5 reveals a styling issue when mixing buttons with & without text labels in button group. The two buttons with text (Move, Cancel) have a height of 33px, whereas all of the remaining buttons (without text) have a height of 30px. This issue occurs here on...

xenforo.com

Additionally, when editing an existing note in FireFox, the textarea height shrinks once it has focus. Some inline CSS is added at this point that was not there pre-focus:

overflow: hidden; overflow-wrap: break-word; height: 56px;

This editing note textarea height issue doesn't seem to affect Chrome.

When adding a new note, the above inline CSS is added without first giving the textarea focus.

 

[djbaxter]

I don't think that is the default style, correct?

What I see in the default style for notes looks like this:

 

[marquisite]

Yes, this is the default style. The screenshot was captured right here on XenForo.com.

Image notes in XenForo Media Gallery are something that you can add to a certain spot on your own XFMG images, such as identifying someone's face or specific points of interest. They were added in XFMG 2 (as a replacement for user tagging in XFMG 1). Image notes are described in more detail in the 'Have you seen...?' post for XFMG below:

What's new in the official add-ons (2.0)

As part of the XenForo 2.0 release, we have updated each of our official add-ons. Primarily, our goal was to update the add-ons to work with the new 2.0 framework and systems. However, each of the add-ons have at least a few new features. Let's look at each add-on in turn...

xenforo.com

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XFMG release (2.1.3).

Change log:

Adjust size of delete button when editing an image note and workaround a sizing issue for the note field in Firefox.

Any changes made as a result of this issue being resolved may not be rolled out here until later.