Closed Missing type hints on various service() methods (already implemented)

[Xon]

Affected version

2.3.13

\XF::service() / \XF\App::service() and a few other places have what amounts to this as a the type definition for the method;

/**
 * @param $class
 * @param mixed ...$arguments
 *
 * @return mixed
 */
public function service($class, ...$arguments)

This can be replaced with a phpdoc template for type hinting the correct return type;

/**
 * @template T of AbstractService
 * @param class-string<T> $class
 * @return T
 */
public static function service(string $class, ...$arguments)

 

[Xon]

Oops, I was looking at an older version of XF