Keyword Alert [Deleted]

[Joe Link]

I also noticed that the "In Title" box doesn't seem to do anything. I assume that's to determine whether or not thread titles are checked as well as posts?

In title box unchecked – Posted keyword in message body – Received Alert
In title box checked – Posted keyword in message body – Received Alert
In title box unchecked – Posted keyword in thread title – Received Alert
In title box checked – Posted keyword in thread title – Received Alert

 

[Oersted]

@fahad ashraf are you going to address the bugs/issues mentioned by @Joe Link ?

 

[fahad ashraf]

@fahad ashraf are you going to address the bugs/issues mentioned by @Joe Link ?

yes that have been solved

 

[Oersted]

Great. Can you please send us the new version?

 

[fahad ashraf]

Great. Can you please send us the new version?

Yes please generate invoice first

 

[Oersted]

@fahad ashraf we are still waiting on the bugs (quoted below) to be fixed, as promised.

Also, found a small bug in the xb_keyword_edit template, causing the page titles and delete button to display incorrectly. Looks like it's because keyword -> send_alert is 1, making it think we're editing an existing keyword.

<xf:if is="!$keyword">
    <xf:title>{{ phrase('xb_add_keyword') }}</xf:title>
<xf:else />
    <xf:title>{{ phrase('xb_edit_keyword:') }} [{$keyword.name}]</xf:title>
</xf:if>

<xf:pageaction if="$keyword">
    <xf:button href="{{ link('account/keywords/delete') }}?keyword_id={$keyword.keyword_id}" icon="delete" overlay="true" />
</xf:pageaction>

I changed $keyword to $keyword.keyword_id and it's working properly now.

<xf:if is="!$keyword.keyword_id">
    <xf:title>{{ phrase('xb_add_keyword') }}</xf:title>
<xf:else />
    <xf:title>{{ phrase('xb_edit_keyword:') }} [{$keyword.name}]</xf:title>
</xf:if>
  
<xf:pageaction if="$keyword.keyword_id">
    <xf:button href="{{ link('account/keywords/delete') }}?keyword_id={$keyword.keyword_id}" icon="delete" overlay="true" />
</xf:pageaction>

I also noticed that the "In Title" box doesn't seem to do anything. I assume that's to determine whether or not thread titles are checked as well as posts?

In title box unchecked – Posted keyword in message body – Received Alert
In title box checked – Posted keyword in message body – Received Alert
In title box unchecked – Posted keyword in thread title – Received Alert
In title box checked – Posted keyword in thread title – Received Alert

 

[Oersted]

Still waiting.

 

[fahad ashraf]

Still waiting.

I still not did any release yet as i will you will got notification no problem

 

[dougdirac]

Any word on XF2.2 compatibility?

 

[fahad ashraf]

it needs to be test in xf2.2 as i am very busy in custom development i will check it if it is not then i will make it

 

[affLIFT]

it needs to be test in xf2.2 as i am very busy in custom development i will check it if it is not then i will make it

Did you ever test this to see if it works in 2.2? Looking for something like it

 

[fahad ashraf]

Did you ever test this to see if it works in 2.2? Looking for something like it

Yes it will work

 

[Oersted]

Still hasn't fixed certain bugs mentioned above...literally years later. Also, found another bug that allows users to get notifications for keywords that are used in forums that they do not have permission to access.

 

[Ozzy47]

I have a client running this addon and have had some odd issues that made us look into some of the code.

Could the following issues be resolved:

• Accessing PHP superglobals (like $_GET without filtering)
• No prepared statements in XenBulletins\KeyWordAlert\Repository\Queue::getQueus
• Missing indexes on table columns that used in JOIN clauses (high performance impact)

That was found doing a quick look, there may be some more to do once you get into the code deeper.

 

[Ozzy47]

I have a client running this addon and have had some odd issues that made us look into some of the code.

Could the following issues be resolved:

• Accessing PHP superglobals (like $_GET without filtering)
• No prepared statements in XenBulletins\KeyWordAlert\Repository\Queue::getQueus
• Missing indexes on table columns that used in JOIN clauses (high performance impact)

That was found doing a quick look, there may be some more to do once you get into the code deeper.

Is this something your going to fix, or should I correct the code for my client?

 

[Paul B]

@fahad ashraf Can you respond to the claims made by @Ozzy47 and if they are valid, can you advise when any code which is non compliant with the standards will be rectified.

Please respond within the next few days or we may be forced to take action.

 

[fahad ashraf]

Is this something your going to fix, or should I correct the code for my client?

I will check and consider it will release new version with all things if they exist

 

[Ozzy47]

I have a client running this addon and have had some odd issues that made us look into some of the code.

Could the following issues be resolved:

• Accessing PHP superglobals (like $_GET without filtering)
• No prepared statements in XenBulletins\KeyWordAlert\Repository\Queue::getQueus
• Missing indexes on table columns that used in JOIN clauses (high performance impact)

That was found doing a quick look, there may be some more to do once you get into the code deeper.

Is this going to be updated to XF coding standards?

 

[fahad ashraf]

Is this going to be updated to XF coding standards?

Yes ofcourse

 

[dougdirac]

Yes ofcourse

Any timeframe on that? It's been a couple months since the issue was raised.