Incorrect % in rating count & the phrase appears in other languages

kick

Well-known member
Affected version
2.3.4
In getResourceRatingSplit
We get this query:
PHP:
$splitRatings = $this->app()->db()->fetchAllKeyed("
       SELECT rating,
              COUNT(*) AS total,
              (COUNT(*) / ?) * 100 AS percentage
       FROM xf_rm_resource_rating
       WHERE resource_id = ?
       AND rating_state = 'visible'
       GROUP BY rating
    ", 'rating', [$resource->review_count, $resource->resource_id]);
But this is an incorrect value, because we get the number of reviews, without rating. Instead of review_count, there should be rating_count
Accordingly, because of this, the % comes out higher.
1735051425154.webp
If the phrase goes to a new line, then an unfilled field is added to the rating
1735051583775.webp
1735051806519.webp
 
Back
Top Bottom