Fixed Fix detection of Opus audio files with .opus instead of .ogg extension

Steffen

Steffen

Well-known member
Affected version
2.2.7
Opus audio files can be uploaded (and rendered as an audio player) when they have a ".ogg" extension. XenForo doesn't recognize them when they have the recommended ".opus" extension (https://en.wikipedia.org/wiki/Opus_(audio_format)). This is easy to fix. :)

Diff: 
diff --git a/src/XF/App.php b/src/XF/App.php
index 51395a939..7cf644589 100644
--- a/src/XF/App.php
+++ b/src/XF/App.php
@@ -349,6 +349,7 @@ class App implements \ArrayAccess
             return [
                 'mp3' => 'audio/mpeg',
                 'ogg' => 'audio/ogg',
+                'opus' => 'audio/ogg',
                 'wav' => 'audio/wav',
             ];
         };

Opus has universal browser support: https://caniuse.com/opus
 
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.8).

Change log:
Add .opus as a supported audio file extension
Click to expand...
There may be a delay before changes are rolled out to the XenForo Community.
 
Has this been implemented? When I attach a file with the .opus extension to a post, the extension gets changed to .ogg during the process. If I then download the .ogg file, it still plays back as Opus. So it seems that XF automatically encapsulates Opus files in the Ogg container. Why does this happen, and can it be avoided? We use Opus files as digital products, and changing their extensions is very misleading.

Does it have to do with the missing 'audio/opus' for 'opus' in the @Steffen’s snippet above?
 
Last edited:
Aivaras said:
Has this been implemented? When I attach a file with the .opus extension to a post, the extension gets changed to .ogg during the process. If I then download the .ogg file, it still plays back as Opus. So it seems that XF automatically encapsulates Opus files in the Ogg container. Why does this happen, and can it be avoided? We use Opus files as digital products, and changing their extensions is very misleading.

Does it have to do with the missing 'audio/opus' for 'opus' in the @Steffen’s snippet above?
Click to expand...
It says it was implemented in 2.2.8 which was quite a while ago. If you're on a current release (2.3), best to open a new bug report since this one is closed. If you're on a version of 2.2 prior to 2.2.8, then you need to upgrade to get the fix.
 
Mendalla said:
It says it was implemented in 2.2.8 which was quite a while ago. If you're on a current release (2.3), best to open a new bug report since this one is closed. If you're on a version of 2.2 prior to 2.2.8, then you need to upgrade to get the fix.
Click to expand...
The issue is present on this forum.
 
Mendalla said:
Then do a new bug report. Old bug reports that are closed as Fixed aren't monitored.
Click to expand...
I believe it would be more convenient for all the parties involved to reopen this bug report rather than create a new one. That way, we can keep all relevant information consolidated in one place.
 
See:
A

Thread '.opus file extension changes to .ogg in Opus file attachments'

When I attach a file with the .opus extension to a post, the extension gets changed to .ogg during the process. If I then download the .ogg file, it still plays back as Opus. So it seems that XF automatically encapsulates Opus files in the OGG container. Why does this happen, and can it be avoided? We use Opus files as digital products, and changing their extensions is very misleading.

A possible cause of the problem may be 'opus' => 'audio/ogg' instead of 'opus' => 'audio/opus' in the snippet below...
 
Aivaras said:
Has this been implemented?
Click to expand...
Yes, this was implementend and thus the reported bug has been fixed.
If thias wasn't fixed, XenForo wouldn't accept .opus files as audio.

Aivaras said:
When I attach a file with the .opus extension to a post, the extension gets changed to .ogg during the process.
Click to expand...
Yes, but this is a different issue.
It is somewhat related to this bug report, but nonetheless a different issue.

Aivaras said:
So it seems that XF automatically encapsulates Opus files in the Ogg container.
Click to expand...
Most likely not.
 
Last edited:
Back
Top Bottom