Dead code in setup.less and many other less templates

K

Kirby

Well-known member
Affected version
2.3.0 Beta 1
Code: 
.m-faBase(@type: false, @weight: false)
{
    // deprecated, use .m-faIcon directly
}

[...]

.m-iconicIcon(@setPosition: true)
{
    [...]

    &:before,
    &:after
    {
        .m-faBase('Pro'; inherit);

All instances of mixin m-faBase probably should probably be removed (it doesn't do anything anyway).
 
We probably won't remove the mixin definition since it could break CSS rendering for outdated styles/add-ons. I guess we could zap the outdated usages, though it's largely benign and the CSS is rewritten for 3.0 anyway so it's not a huge priority.
 
Yeah, I was only taking about the usages which are now basically NOPs.

Definitly not a real issue, but I like things to be clean so I reported it :)
 
Top Bottom