XF 2.3 Can't upgrade to 2.3.4 "Invalid icon variant: duo"

[Newsman]

Hey y'all,

tried to upgrade both via the ACP and via CLI, but always get this error:

InvalidArgumentException: Invalid icon variant: duo src\XF\Service\Icon\UsageAnalyzerService.php:675

#0 src\XF\Service\Icon\UsageAnalyzerService.php(898): XF\Service\Icon\UsageAnalyzerService->recordIcon('javascript', '8b5edf3858b6635...', 'sprite', 'duo', 'fa-times-circle')
#1 src\XF\Service\Icon\UsageAnalyzerService.php(301): XF\Service\Icon\UsageAnalyzerService->recordIconsFromJavascript('javascript', '8b5edf3858b6635...', 'const   CLASS_S...')
#2 src\XF\MultiPartRunnerTrait.php(88): XF\Service\Icon\UsageAnalyzerService->stepJavascript(NULL, 4.34401)
#3 src\XF\Service\Icon\UsageAnalyzerService.php(113): XF\Service\Icon\UsageAnalyzerService->runLoop(4.3481)
#4 src\XF\Job\IconUsage.php(45): XF\Service\Icon\UsageAnalyzerService->analyze(4.3481)
#5 src\XF\Job\Atomic.php(40): XF\Job\IconUsage->run(4.3481)
#6 src\XF\Job\Manager.php(275): XF\Job\Atomic->run(8)
#7 src\XF\Job\Manager.php(205): XF\Job\Manager->runJobInternal(Array, 8)
#8 src\XF\Job\Manager.php(89): XF\Job\Manager->runJobEntry(Array, 8)
#9 src\XF\Admin\Controller\ToolsController.php(165): XF\Job\Manager->runQueue(true, 8)
#10 src\XF\Mvc\Dispatcher.php(362): XF\Admin\Controller\ToolsController->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src\XF\Mvc\Dispatcher.php(265): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\ToolsController), NULL)
#12 src\XF\Mvc\Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\ToolsController), NULL)
#13 src\XF\Mvc\Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src\XF\App.php(2826): XF\Mvc\Dispatcher->run()
#15 src\XF.php(806): XF\App->run()
#16 admin.php(15): XF::runApp('XF\\Admin\\App')
#17 {main}

Obviously I have not modified any of the XF files so I don't know what the exact issue is or how I can solve it.. is my upgrade package corrupted?

 

[Newsman]

HELP!

 

[Jeremy P]

Ideally we should make some changes to handle this more gracefully, but this is ultimately going to be caused by an add-on with a JavaScript file that's doing something like...

XF.Icon.getIcon('duo', 'fa-times-circle')
// (the correct variant is duotone and not duo)

 

[Newsman]

Ideally we should make some changes to handle this more gracefully, but this is ultimately going to be caused by an add-on with a JavaScript file that's doing something like...

XF.Icon.getIcon('duo', 'fa-times-circle')
// (the correct variant is duotone and not duo)

Huh, turns out this was indeed the issue - but weirdly enough, I had those lines commented out, so they shouldn't have been considered in the first place..

Anyways, thanks Jeremy!