Amazon/eBay Parser 2.1.4

[lightspeed]

Looks like ebay is changing their tracking link format. Will this plugin still work with the new link format?

This month, eBay Partner Network will move from rover-based tracking links to a new tracking link format, which will comply with industry standards and fully support Tracking Prevention Frameworks such as Apple Webkit ITP, Mozilla Firefox ETP, or Microsoft Edge Tracking Prevention.

On Thursday, February 18, all ePN tools and widgets and eBay's Data Feeds and Browse APIs will automatically start serving the new tracking links.

All remaining rover-based links you have shared will need to be replaced with the new tracking links by Wednesday, March 31. Start converting links today with our helpful new Link Conversion tool, part of the Smart Share browser extension.

 

[Ozzy47]

Yes, the addon might need an update.

 

[lightspeed]

No worries, thanks for the fast reply. Hopefully it's not too difficult to implement the new link format.

 

[Ozzy47]

I don’t know that this addon user rover links though?

 

[briansol]

yeah it's in there...

$tempurl = "http://rover.ebay.com/rover/1/%s/1?pub=%s&toolid=%s&campid=%s&customid=%s&mpt=" . $cachebuster;

trying to hack it myself but not getting very far

 

[briansol]

until this is updated, i removed the entries for ebay in the admincp and put ebay's js snippet on

https://partner.ebay.com/secure/mediapartner/ads/view-flexi-flow.ihtml?execution=e2s1

really don't want to run more js (and it won't work on amp pages ) so i do look forward to this being updated.

 

[Ozzy47]

@briansol do you have a test site to try out a fix?

 

[briansol]

yeah, i can install a beta

 

[Ozzy47]

I’ll send you a PC.

 

[briansol]

That's very kind of you. A pm would be all that's needed

 

[Ozzy47]

 

[Ozzy47]

Ozzy47 updated Amazon/eBay Parser with a new update entry:

[OzzModz] Amazon/eBay Parser for XenForo 2.1+ Update 2.1.2

Updated for the new eBay tracking link structure.

Read the rest of this update entry...

 

[rdn]

Is this PHP8 incompatible?
I got several of this error.

ErrorException: Template error: [E_WARNING] Undefined variable $tempurl src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php:287
Generated by: Unknown account Feb 24, 2021 at 10:18 AM
Stack trace
#0 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(287): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Und...', '/home/nginx/dom...', 287)
#1 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(44): Snog\Amazon\XF\BbCode\Renderer\Html->addCampaignToHref('<a href="http:/...', Array)
#2 [internal function]: Snog\Amazon\XF\BbCode\Renderer\Html->renderTagUrl(Array, 'http://rover.eb...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#3 src/XF/BbCode/Renderer/Html.php(308): call_user_func(Array, Array, 'http://rover.eb...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#4 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#6 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(XF\BbCode\RuleSet), Array)
#7 src/XF/SubContainer/BbCode.php(220): XF\BbCode\Traverser->render('pretty sure I m...', Object(XF\BbCode\Parser), Object(XF\BbCode\RuleSet), Array)
#8 src/XF/Template/Templater.php(2343): XF\SubContainer\BbCode->render('pretty sure I m...', 'html', 'post', Object(XFES\XF\Entity\Post), Array)
#9 [internal function]: XF\Template\Templater->fnBbCode(Object(XF\Template\Templater), false, 'pretty sure I m...', 'post', Object(XFES\XF\Entity\Post))
#10 src/XF/Template/Templater.php(1103): call_user_func_array(Array, Array)
#11 internal_data/code_cache/templates/l1/s8/public/post_macros.php(476): XF\Template\Templater->func('bb_code', Array, false)
#12 src/XF/Template/Templater.php(799): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, NULL)
#13 internal_data/code_cache/templates/l1/s8/public/post_macros.php(66): XF\Template\Templater->callMacro('post_macros', 'post_user_conte...', Array, Array)
#14 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#15 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('user_content', Array, Array, Object(XF\Template\ExtensionSet))
#16 internal_data/code_cache/templates/l1/s8/public/post_macros.php(100): XF\Template\Templater->renderExtension('user_content', Array, Object(XF\Template\ExtensionSet))
#17 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#18 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('content', Array, Array, Object(XF\Template\ExtensionSet))
#19 internal_data/code_cache/templates/l1/s8/public/post_macros.php(135): XF\Template\Templater->renderExtension('content', Array, Object(XF\Template\ExtensionSet))
#20 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#21 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('main_cell_inner', Array, Array, Object(XF\Template\ExtensionSet))
#22 internal_data/code_cache/templates/l1/s8/public/post_macros.php(149): XF\Template\Templater->renderExtension('main_cell_inner', Array, Object(XF\Template\ExtensionSet))
#23 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#24 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('main_cell', Array, Array, Object(XF\Template\ExtensionSet))
#25 internal_data/code_cache/templates/l1/s8/public/post_macros.php(161): XF\Template\Templater->renderExtension('main_cell', Array, Object(XF\Template\ExtensionSet))
#26 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#27 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('full_body', Array, Array, Object(XF\Template\ExtensionSet))
#28 internal_data/code_cache/templates/l1/s8/public/post_macros.php(200): XF\Template\Templater->renderExtension('full_body', Array, Object(XF\Template\ExtensionSet))
#29 src/XF/Template/Templater.php(799): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#30 internal_data/code_cache/templates/l1/s8/public/thread_view.php(794): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#31 src/XF/Template/Templater.php(1626): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#32 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#33 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#34 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#35 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#36 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#37 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#38 src/XF/App.php(2326): XF\Mvc\Dispatcher->run()
#39 src/XF.php(488): XF\App->run()
#40 index.php(20): XF::runApp('XF\\Pub\\App')
#41 {main}

Thank you.

 

[Ozzy47]

Possibly not yet.

 

[askandy]

@Ozzy47 - just installed the updated version of the add-on, and it looks like it's breaking our links.

When the add-on is disabled, the links look something like this:

https://rover.ebay.com/rover/1/711-53200-19255-0/1?mpre=https%3A%2F%2Fpages.ebay.com%2Fauthenticity-guarantee-watches%2F&campid=5338767072&toolid=10001&customid=

When I enable the add-on, on the same page/link, it looks like this:

https://askandyaboutclothes.com/community/threads/ebay-authenticity-guarantee-luxury-watches.243315/https%3A%2F%2Fpages.ebay.com%2Fauthenticity-guarantee-watches%2F&mkevt=1&mkcid=1&mkrid=711-53200-19255-0&siteid=0&customid=&campid=5338789942&toolid=10001&mpt=9770681

Obviously, the above is a broken link.

This is a good test page (I have the add-on disabled right now):

https://askandyaboutclothes.com/community/threads/ebay-authenticity-guarantee-luxury-watches.243315/

This is the post that has the example link from above:

official - ⌚ eBay Authenticity Guarantee: Rolex, Omega...

askandyaboutclothes.com

If I can find a way to revert back to the prior version, I will and see what happens.

Thoughts?

 

[Ozzy47]

Sent you a PC

 

[dougdirac]

We recently upgraded to XF2.2 and installed this addon. Getting these errors periodically. We're on php7.4.

• ErrorException: [E_NOTICE] Undefined variable: tempurl
• src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php:287
• Generated by: Unknown account
• Mar 11, 2021 at 2:39 PM

#0 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(287): XF::handlePhpError(8, '[E_NOTICE] Unde...', 'sr...', 287, Array)
#1 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(44): Snog\Amazon\XF\BbCode\Renderer\Html->addCampaignToHref('<a href="https:...', Array)
#2 [internal function]: Snog\Amazon\XF\BbCode\Renderer\Html->renderTagUrl(Array, 'https://rover.e...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#3 src/XF/BbCode/Renderer/Html.php(308): call_user_func(Array, Array, 'https://rover.e...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#4 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#6 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(XF\BbCode\RuleSet), Array)
#7 src/XF/Pub/View/FeedHelper.php(118): XF\BbCode\Traverser->render('Looking to try ...', Object(XF\BbCode\Parser), Object(XF\BbCode\RuleSet), Array)
#8 src/XF/Pub/View/Forum/Rss.php(42): XF\Pub\View\FeedHelper::setupEntryForThread(Object(Laminas\Feed\Writer\Entry), Object(XFMG\XF\Entity\Thread), 'last_post_date')
#9 src/XF/Mvc/Renderer/AbstractRenderer.php(91): XF\Pub\View\Forum\Rss->renderRss()
#10 src/XF/Mvc/Renderer/Xml.php(74): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('XF:Forum\\Rss', '', Array)
#11 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Xml->renderView('XF:Forum\\Rss', '', Array)
#12 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'rss')
#15 src/XF/App.php(2326): XF\Mvc\Dispatcher->run()
#16 src/XF.php(488): XF\App->run()
#17 index.php(20): XF::runApp('XF\\Pub\\App')
#18 {main}

 

[Ozzy47]

What’s the actual error?

 

[dougdirac]

What’s the actual error?

[E_NOTICE] Undefined variable: tempurl

 

[Ozzy47]

You sure your on PHP 7.4 and not 8.x ?