Reply to thread

Message

<blockquote data-quote="Kirby" data-source="post: 1564990" data-attributes="member: 1059">Yes, definitly. If it is not passed it would most likely require a bit more code than necessary as we would only need additional joins depending on the specific search forum that is going to be displayed.The new method [ICODE]getUserCacheExtraWith()[/ICODE] does not have direct access to this information - to get it I would probably have to duplicate some code from [ICODE]actionView()[/ICODE] which seems unnecessary overhead if it could just be passed <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Ideally the patch could be smth. like[CODE=&quot;diff&quot;]diff --git a/src/XF/Pub/Controller/SearchForum.php b/src/XF/Pub/Controller/SearchForum.phpindex e9795faddf..8b05b847d9 100644--- a/src/XF/Pub/Controller/SearchForum.php+++ b/src/XF/Pub/Controller/SearchForum.php@@ -56,7 +56,7 @@ public function actionView(ParameterBag $params)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; $searchForum&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; );&nbsp;-&nbsp; &nbsp; &nbsp; &nbsp; $threads = $userCache-&gt;getThreadsByPage($page, $perPage);+&nbsp; &nbsp; &nbsp; &nbsp; $threads = $userCache-&gt;getThreadsByPage($page, $perPage, $this-&gt;getUserCacheExtraWith($searchForum));&nbsp;&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; $canInlineMod = false;&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; foreach ($threads AS $thread)@@ -108,6 +108,14 @@ protected function getSearchForumViewExtraWith()&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; return [&#039;Cache&#039;, &quot;UserCaches|{$visitor-&gt;user_id}&quot;];&nbsp; &nbsp;&nbsp; }&nbsp;+&nbsp; &nbsp; /**+&nbsp; &nbsp;&nbsp; * @return string[]+&nbsp; &nbsp;&nbsp; */+&nbsp; &nbsp; protected function getUserCacheExtraWith(\XF\Entity\SearchForum $searchForum): array+&nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; return [];+&nbsp; &nbsp; }+&nbsp; &nbsp;&nbsp; /**&nbsp; &nbsp; &nbsp; * @return \XF\Mvc\Reply\AbstractReply&nbsp; &nbsp; &nbsp; */[/CODE]This way the SearchForum entity could be accessed directly.</blockquote>

[QUOTE="Kirby, post: 1564990, member: 1059"] Yes, definitly. If it is not passed it would most likely require a bit more code than necessary as we would only need additional joins depending on the specific search forum that is going to be displayed. The new method [ICODE]getUserCacheExtraWith()[/ICODE] does not have direct access to this information - to get it I would probably have to duplicate some code from [ICODE]actionView()[/ICODE] which seems unnecessary overhead if it could just be passed :) Ideally the patch could be smth. like [CODE="diff"]diff --git a/src/XF/Pub/Controller/SearchForum.php b/src/XF/Pub/Controller/SearchForum.php index e9795faddf..8b05b847d9 100644 --- a/src/XF/Pub/Controller/SearchForum.php +++ b/src/XF/Pub/Controller/SearchForum.php @@ -56,7 +56,7 @@ public function actionView(ParameterBag $params) $searchForum ); - $threads = $userCache->getThreadsByPage($page, $perPage); + $threads = $userCache->getThreadsByPage($page, $perPage, $this->getUserCacheExtraWith($searchForum)); $canInlineMod = false; foreach ($threads AS $thread) @@ -108,6 +108,14 @@ protected function getSearchForumViewExtraWith() return ['Cache', "UserCaches|{$visitor->user_id}"]; } + /** + * @return string[] + */ + protected function getUserCacheExtraWith(\XF\Entity\SearchForum $searchForum): array + { + return []; + } + /** * @return \XF\Mvc\Reply\AbstractReply */[/CODE] This way the SearchForum entity could be accessed directly. [/QUOTE]

Verification