AbstractJob::resume() assumes getStatusMessage non-nullable return value

X

Xon

Well-known member
Affected version
2.3.7
XF2.3 added a method JobResult::newResume() which had typed arguments and the AbstractJob::resume() assumes getStatusMessage() a stringable but the getStatusMessage method was never type hinted for a return type and I've seen it return null in a few of my add-ons and a few 3rd party add-ons.

I think the best fix would be for ?? '' to be added in the resume() method and a ?string return type hint added to getStatusMessage() method.
 
Back
Top Bottom