Fixed Type hinting on cleanUpInvalidRecords & filterViewableUnapprovedItems are inconsistent with out methods

[Xon]

Affected version

2.3.6

filterViewableUnapprovedItems should be type hinting AbstractCollection<ApprovalQueue> not ArrayCollection

cleanUpInvalidRecords should be hinted as AbstractCollection<ApprovalQueue>. This will throw some type conflicts with the current array type hint, so maybe adding AbstractCollection<ApprovalQueue>|ApprovalQueue[] or using iterable<ApprovalQueue>

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.8).

Change log:

Fix `cleanUpInvalidRecords` type hint

There may be a delay before changes are rolled out to the XenForo Community.