Fixed Incorrect % in rating count & the phrase appears in other languages

[kick]

Affected version

2.3.4

In getResourceRatingSplit
We get this query:

$splitRatings = $this->app()->db()->fetchAllKeyed("
       SELECT rating,
              COUNT(*) AS total,
              (COUNT(*) / ?) * 100 AS percentage
       FROM xf_rm_resource_rating
       WHERE resource_id = ?
       AND rating_state = 'visible'
       GROUP BY rating
    ", 'rating', [$resource->review_count, $resource->resource_id]);

But this is an incorrect value, because we get the number of reviews, without rating. Instead of review_count, there should be rating_count
Accordingly, because of this, the % comes out higher.

If the phrase goes to a new line, then an unfilled field is added to the rating

 

[akok]

yes, there is such a thing

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFRM release (2.3.10).

Change log:

Use rating_count instead of review_count for rating percentage calculation

There may be a delay before changes are rolled out to the XenForo Community.