• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Recent content by Steffen

  1. S

    Fixed vBulletin 4.x Import: "Could not find XF:Usergroup handler"

    diff --git a/xenforo/src/XF/Import/Importer/vBulletin.php b/xenforo/src/XF/Import/Importer/vBulletin.php --- a/xenforo/src/XF/Import/Importer/vBulletin.php +++ b/xenforo/src/XF/Import/Importer/vBulletin.php @@ -435,7 +435,7 @@ class vBulletin extends AbstractForumImporter if...
  2. S

    Fixed IP information URL: Remove "::ffff:" prefix from IPv4-mapped IPv6 addresses

    I did not know that there already was a special path for IPv4 addresses. Then it makes sense to treat IPv4-mapped IPv6 addresses like normal IPv4 addresses. Thanks, Mike!
  3. S

    Fixed IP information URL: Remove "::ffff:" prefix from IPv4-mapped IPv6 addresses

    I did not say that IPv6 dwarfs IPv4 right now but that it probably will in a few years. At the current rate, IPv6 will probably overtake IPv4 within 3-4 years on our website. And I said that your mileage may vary. However, I agree that "overtakes" or "surpases" would have been a more appropriate...
  4. S

    Fixed IP information URL: Remove "::ffff:" prefix from IPv4-mapped IPv6 addresses

    I would not worry about "wasting 12 bytes of storage per IP record" because IPv6 usage is growing like crazy and will probably dwarf legacy IPv4 traffic in just a few years. I've attached a graph that shows IPv6 usage on ComputerBase over time. IPv6 usage probably differs by country but the...
  5. S

    Fixed IP information URL: Remove "::ffff:" prefix from IPv4-mapped IPv6 addresses

    I've set the "IP information URL" to "https://ipinfo.io/{ip}". But ipinfo.io doesn't seem to support IPv4-mapped IPv6 addresses: https://ipinfo.io/%3A%3Affff%3A87.230.75.2 However, everything is fine if you strip the "::ffff:" prefix: https://ipinfo.io/87.230.75.2 This could be considered a...
  6. S

    Fixed Stop Forum Spam: Use HTTPS and "emailhash" for better privacy

    I have two suggestions to improve the Stop Forum Spam integration of XenForo. :) 1. This is the easy one: Stop Forum Spam supports HTTPS. Please update the class "XF\Spam\Checker\StopForumSpam" such that it uses HTTPS instead of HTTP (two spots). This should not cause any problems, SFS has been...
  7. S

    Partial fix IPv4-mapped IPv6 addresses: Improve formatting and simplify code

    Thank you for the changes to make IPv4-mapped IPv6 addresses more readable! I did not know that the native PHP functions might not exist (could be detected), might not support IPv6 (could probably be detected as shown in the linked PHP test-case) or might just be broken on macOS (could be...
  8. S

    Partial fix IPv4-mapped IPv6 addresses: Improve formatting and simplify code

    Take the IPv4 address 192.168.123.123. XenForo internally stores it as an IPv4-mapped IPv6 address which totally makes sense. But when displaying this IP address, XenForo formats it as "::ffff:c0a8:7b7b" which is technically correct but I dont' think it's very user-friendly. In fact, XenForo is...
  9. S

    Implemented XF2: Please add method XF\Service\Post\Editor::setPerformValidations

    Thank you for the reply. Using 'XF\Pub\App' instead of 'XF\App' is what I described as a "workaround" in the first post. If it is not a workaround but totally fine to use 'XF\Pub\App' in CLI mode then everything is fine. :) (I thought that using 'XF\Pub\App' was only appropriate when serving...
  10. S

    Implemented XF2: Please add method XF\Service\Post\Editor::setPerformValidations

    Thank you for adding the suggested method to Post\Editor! Using XenForo 2.0 Beta 6 and the script posted above, I'm still getting the mentioned error. Here is the stack trace: An exception occurred: [LogicException] The router key must be overridden. in src/XF/App.php on line 269 #0...
  11. S

    Fixed [XF2] Redis Cache: Workaround for default value of "persistent_id"

    Using PHP 7.1.9 + Phpredis 3.1.3 / 3.1.4 RC1, I'm trying to make XenForo 2.0 Beta 2 share a persistent Redis connection with other PHP code. XenForo uses an empty string as a default value for the "persistent_id". Unfortunately, Phpredis does not treat an empty string the same as omitting the...
  12. S

    Implemented XF2: Please add method XF\Service\Post\Editor::setPerformValidations

    The class XF/Service/Thread/Editor has a method setPerformValidations. I think XF\Service\Post\Editor should have such a method, too. It should be used to skip the PostPreparer validation called by XF\Service\Post\Editor::setMessage, just like the ThreadEditor does. Reasoning: I'm using the...