Recent content by Steffen

  1. Steffen

    Search query tokenizer turns query "term1 - term2" into "term1 -term2" (i.e. it negates term2)

    The search query tokenizer of XenForo turns the query "term1 - term2" into "term1 -term2" (it removes the whitespace in front of "term2" and therefore negates it). I think this is not intuitive and doesn't match the behaviour of Elasticsearch's "simple_query_string" tokenzier either. This can...
  2. Steffen

    XF301VB: Add missing redirect for newthread.php URLs

    This may not strictly be a bug but can be easily patched. :) --- a/src/addons/XF301VB/Mvc/Router.php +++ b/src/addons/XF301VB/Mvc/Router.php @@ -107,11 +120,13 @@ class Router extends XFCP_Router case 'printthread.php': case 'showpost.php': case...
  3. Steffen

    XF301VB: Fix for feed redirects

    Without this patch, feed URLs are redirected to the forum view. --- a/src/addons/XF301VB/Pub/Controller/Redirect.php +++ b/src/addons/XF301VB/Pub/Controller/Redirect.php @@ -155,7 +155,7 @@ class Redirect extends Controller return $this->noPermission(); }...
  4. Steffen

    XF301VB\Mvc\Router::routeToController misses two "break" statements

    --- XF301VB/Mvc/Router.php 2018-09-20 08:37:31.844287072 +0200 +++ XF301VB/Mvc/Router.php 2018-09-20 08:37:52.938162747 +0200 @@ -220,6 +220,7 @@ { return $match; } + break; } // vB3 / vB4...
  5. Steffen

    Warn member: "fitHeight" problem with the conversation message textarea

    @Chris D This issue doesn't seem to be fixed in XenForo 2.0.10. Could you please have another look?
  6. Steffen

    DuplicateKeyException: Duplicate entry 'post-123-456' for key 'content_type_id_like_user_id'

    I think this issue is similar to the issue "DuplicateKeyException: Duplicate entry 'thread-123-456' for key 'draft_key_user'". XF\Db\DuplicateKeyException: MySQL query error [1062]: Duplicate entry 'post-123-456' for key 'content_type_id_like_user_id' src/XF/Db/AbstractStatement.php:212...
  7. Steffen

    Fixed XF301VB: Categories aren't redirected properly

    Yeah, the additional dot doesn't seem to cause any issues besides looking strange. (I may have assumed that this wouldn't work without actually testing it back in May.)
  8. Steffen

    Duplicate XF301VB: Bad entry in $simpleMap

    The fix is correct. Although I'd still argue that this redirect should be changed to /watched/threads because the vB4 usercp.php lists watched threads and watched forums (https://xenforo.com/community/threads/xenforo-redirects-for-vbulletin-xf301vb-suggestions-for-more-urls-2.144618/post-1234337).
  9. Steffen

    Fixed XF301VB: Categories aren't redirected properly

    In our case, without the str_replace hack the redirect URL for https://www.computerbase.de/forum/forumdisplay.php?f=1 is https://www.computerbase.de/forum/.#arbeitsspeicher-mainboards-und-cpus.1 instead of https://www.computerbase.de/forum/#arbeitsspeicher-mainboards-und-cpus.1 Node 1 is a...
  10. Steffen

    Fixed Broken Change Log

    Yeah, this could be fixed by adding "word-break: normal" to the generated-content ::before elements.
  11. Steffen

    Editor contents scrolled out of sight when focusing editor with lots of text

    At least in Chrome for Android (I haven't tested this in other browsers but our users say that it affects Firefox for Android, too) there is the following issue: When focusing an editor with lots of text (such that it doesn't auto-expand anymore, like here) the editor contents are scrolled out...
  12. Steffen

    Fixed Structured data Breadcrumblist error

    Alternatively, XenForo could use the JSON-LD markup for breadcrumbs which seems to be the prefered format for structured data nowadays: https://developers.google.com/search/docs/data-types/breadcrumb (Also needs a "position" attribute but feels less awkward than meta tags in your <body>.)
  13. Steffen

    Fixed Broken Change Log

    Have you tried adding word-break: break-word; only to the "old" and "new" cells (i.e. not to the whole table)? :)
  14. Steffen

    Fixed Broken Change Log

    I've seen that issue, too. I've just tested in the Chrome developer tools that adding word-break: break-word; to the table cells fixes it.
Top