Recent content by Justis R

  1. Justis R

    Fixed core_utilities.less spaceBefore incorrect margin

    u-spaceBefore and u-spaceAfter both apply margin to the right. Surely u-spaceBefore is intended to apply the margin to the left.
  2. Justis R

    XF 2.2 disabler and <xf:dependent> not working inside menu dropdown

    Seems to be an issue caused due to the combination of the form and the menu with the menu content as a direct child. Switching to an href for the menu circumvents the issue although it's a bit of a pain in the ass.
  3. Justis R

    XF 2.2 Recommended approach for changing post author on the fly?

    Extend XF\Pub\Controller\Thread override setupThreadReply, call the parent first to get the generated Replier then do your checks for whether or not you want to change the post author. If you do, call Replier#setUser to set the post author to whichever user you want and return the Replier. This...
  4. Justis R

    XF 2.2 disabler and <xf:dependent> not working inside menu dropdown

    The form works as expected outside of a menu, but when moved into my menu, the dependent fields stop working. If data-hide is true on the toggle option, the child options will be both visible and disabled regardless of whether or not the option is selected. I data-hide is on the toggle option...
  5. Justis R

    XF 2.2 xf-dev:import fails to import all files

    Update! After weeks of xf-dev:import not importing the template mods or any phrases, despite all of them being present in the output folder, I thought I'd try doing a xf-addon:export, exported the _data files. Took a look inside and they were incomplete, just like on the board. Ran...
  6. Justis R

    XF 2.2 xf-dev:import fails to import all files

    It imports everything but the template mods and the phrases. Someone please help. I'm going to cry.
  7. Justis R

    XF 2.2 xf-dev:import fails to import all files

    I pulled another class extension and ran the import and experienced the same issue once again with the class extension not being imported, without errors. Seems to solely effect class extensions. EDIT: Nvm, it seems it's also not importing any phrases as well. I don't understand.
  8. Justis R

    TokenInputRow could handle existing values better

    @Kirby Tagging you since you liked this thread, so I assume you had the same issue as I did. Turns out you can fill in the list-data property with a json map, to supply an id => name mapping for pre-existing values. What tripped me up, is that you also need to fill in the value property with...
  9. Justis R

    XF 2.2 xf-dev:import fails to import all files

    I'm collaborating with another developer on a particular addon, and as quoted here: I pulled his changes, confirmed the files were as expected, then ran xf-dev:import and then rebuilt the caches. Most of the changes seem to have been imported correctly. Templates, routes, controllers...
  10. Justis R

    field-adder not null checking name attribute before performing a replace

    This is also an issue with the xf:tokeninput, since unnamed inputs are generated.
  11. Justis R

    field-adder not null checking name attribute before performing a replace

    This makes field-adder incompatible with various inputs, such as a file upload from helper_attach_upload. A null check before attempting the counter replace would surely fix it.
  12. Justis R

    As designed Inforow breaks contentcheck

    <xf:if contentcheck="true"> <xf:inforow> <xf:contentcheck> <!-- Stuff --> </xf:contentcheck> </xf:inforow> </xf:if> This produces the error: "Tag must be a valid conditional using an is attribute or content checking" on the "<xf:if/>" A minor issue, there are...
  13. Justis R

    TokenInputRow could handle existing values better

    The tokeninputrow href expects a response mapping an id to a display text for a provided query, when the tokeninputrow is submitted, the id is what's submitted, not the display text, which is ideal. However, the tokeninputrow only accepts a comma separated list of strings as the value, and those...
  14. Justis R

    Not a bug Unexpected (but understandable) js-disabler behavior

    When a js-disabler is used in a popup and that popup is closed, then another popup is opened which uses the same template, the js-disabler will become confused and stop working, because there's now multiple triggers and targets with the same ids registered to the page: I've circumvented the...
  15. Justis R

    Unable to disable fields within an active js-disabler target container

    Got a disabler target container with a bunch of form fields inside. Some of the fields have individual disable conditions on them so that even if the parent div is active, individual fields can still be disabled based on field specific conditions, however when the parent container is active the...
Top Bottom