Fixed XF\Finder\ConversationMessage->forFullView() missing User.Profile

[digitalpoint]

Affected version

2.x

Shouldn't the "with" statement here contain User.Profile also?

Not having it (like it is now) adds a query per user that is part of the conversation when viewing the conversation.

$this->with('User');

vs

$this->with(['User', 'User.Profile']);

On a side note, it is pretty slick how XF2 will go and query what's needed when it was missing in the original join.

 

[Chris D]

On a side note, it is pretty slick how XF2 will go and query what's needed when it was missing in the original join.

The bad bit is, it does a good job of hiding issues like this, of course

 

[digitalpoint]

The bad bit is, it does a good job of hiding issues like this, of course

True... would be a nice config debugging option to disable it to run through quick tests.