[WMTech] Double Post Merge 1.3.1

[HittingSmoke]

I'm having an issue with this and editing. When editing a post that has posts merged into it the only text that appears in the editor is from the original post. None of the merged posts appear in the editor for me.

 

[Syndol]

None of the merged posts appear in the editor for me.

What you are saying is not possible as merged text is saved with the original post.

 

[Syndol]

Syndol updated Double Post Merge with a new update entry:

Version 1.0.8

What's New:

• Added option to merge posts without the tag that separates the two posts. To do this, simply leave the Double Post Tag Text input box empty (options page).
• Adjusted code to work with XenForo 1.3.x

Upgrade Instructions:

1. Upload the file 'Upload/library/DoublePost/ControllerPublic/Thread.php' to your server overwriting the old one.
   
2. Upload the file 'Upload/library/DoublePost/BbCode/Formatter/Base.php' to your server overwriting the old one....

Read the rest of this update entry...

 

[rdn]

Very useful addon
Thanks !

 

[TDUBS]

This caused major errors in my Server Logs for 1.3.

See: http://xenforo.com/community/threads/illegal-string-offset-relative.70626/

 

[rdn]

I'm using this on my Live Forum with XF 1.3.0 without any problem.

 

[Moshe1010]

This caused major errors in my Server Logs for 1.3.

See: http://xenforo.com/community/threads/illegal-string-offset-relative.70626/

I think this add-on is your problem:
http://xenforo.com/community/resources/hashtagging.2110/

There is a conflict.

 

[TDUBS]

I think this add-on is your problem:
http://xenforo.com/community/resources/hashtagging.2110/

There is a conflict.

I disabled 'double posting' and it was fine. Do you reckon if I uninstall hashtagging that double posting would be fine?

 

[Moshe1010]

I disabled 'double posting' and it was fine. Do you reckon if I uninstall hashtagging that double posting would be fine?

Try to disable hashtagging and enable Double posting and see what happens.

 

[TDUBS]

Try to disable hashtagging and enable Double posting and see what happens.

Yeah, I noticed there's no errors that way. I prefer this plugin over the hashtagging anyways... just added it for fun.

 

[chickenputty]

Found a bug, here is how you can reproduce it:

User 1: Posts
User 1: Posts again to cause a double post
User 1: Edit's their post and removes the last bracket

We now have a post that looks like so,

Test[DOUBLEPOST=1397614926,1397614923][/DOUBLEPOST

Visually:

To cause the main part of the bug,

User 2: Quotes User 1's post and writes a reply

The result is the reply missing and only the double post text showing

[QUOTE="chickenputty, post: 211844, member: 2"]Test[DOUBLEPOST=1397614926,1397614923][/DOUBLEPOST[/QUOTE]
Test 4

So the users content is missing because of the lack of the end bracket in the double post.

~~~~

Above is the only way that this bug can be an issue. If someone removes the end bracket in their own post the content afterwards will be lost, but no one is affected from that.
I'm a bit confused why it was coded to need the [/DOUBLEPOST] ending, but I guess that's your choice.

 

[Syndol]

The closing tag is needed for when a double post is quoted or a single post is compromised of multiple double posts.
The tag has its faults and as you mentioned can be broken or completely manipulated (date wise for example) by editing it.
If your user base cannot be trusted not to edit the tags then I would recommend using the feature where double posts are simply divided by a break line and therefore there is no tag to be messed with.
If you think there is a better way of handling double posts then you are more than welcome to modify this add-on as you see fit and then release it as an alternative, or even a replacement, add-on.

 

[TDUBS]

The closing tag is needed for when a double post is quoted or a single post is compromised of multiple double posts.
The tag has its faults and as you mentioned can be broken or completely manipulated (date wise for example) by editing it.
If your user base cannot be trusted not to edit the tags then I would recommend using the feature where double posts are simply divided by a break line and therefore there is no tag to be messed with.
If you think there is a better way of handling double posts then you are more than welcome to modify this add-on as you see fit and then release it as an alternative, or even a replacement, add-on.

So can the manipulation not be stopped, or are we supposed to rely on our members being "trusted?"

 

[Syndol]

So can the manipulation not be stopped, or are we supposed to rely on our members being "trusted?"

Either that, use the tag-less option, or not use the add-on at all.

 

[TDUBS]

Either that, use the tag-less option, or not use the add-on at all.

As the author of this plugin, I would've hoped you'd at least do a minor update on fixing this.

 

[Syndol]

As the author of this plugin, I would've hoped you'd at least do a minor update on fixing this.

Sometimes you guys just make me laugh
If you have a quick fix for us all then please do share!

 

[Syndol]

Syndol updated Double Post Merge with a new update entry:

Version 1.0.9

What's new:

• Added two new alert templates in order not to receive a second 'Thread Created' alert when the first post is merged.
  
• Fixed the Forum Watch alerts as that used to send out alerts even when the user has not yet viewed the thread.

Read the rest of this update entry...

 

[TDUBS]

Good to see an update. Thanks!

 

[Syndol]

You're welcome but I still have no solution to people editing their posts.

 

[TDUBS]

You're welcome but I still have no solution to people editing their posts.

All good. Sorry if I sounded rude when I was replying.. I thought maybe you had one, just didn't want to share/update.