This statement is basically the opposite of that of the people who worship it. Neither position is factually correct. Going from vB 3.x without to with vBSEO we saw evidence of increased traffic and better ranking. This evidence however doesn't show that vBSEO is essential, that it can't be replaced by something else, or that it's required for other products including vB 4.x or XF. Those are separate claims that need to be investigated. But to say that vBSEO has no effect, or that it's wasted money is simply not true. Even if there's a free alternative in multiple free add-ons, they may require more time to maintain.
Moving on - no point strictly debating the merits of vBSEO here. If you think there are things of value in it that XF would benefit from, then by all means suggest them.