[Tinhte] Image Attachment Optimization 2.3.0 20170315

[MattW]

Could you Please upload new files and check again?

This has fixed the issue. I was having the same problem on my dev server using nginx as it's not using the friendly URLs

 

[Brent W]

This breaks the lightbox pop up navigation for me. Disabling this product fixes it. Go to this post and try to navigate: http://www.shottalk.com/threads/first-round-of-2013.33818/#post-384901

 

[rdn]

This breaks the lightbox pop up navigation for me. Disabling this product fixes it. Go to this post and try to navigate: http://www.shottalk.com/threads/first-round-of-2013.33818/#post-384901

Do you mean: http://www.shottalk.com/misc/quick-navigation-menu?selected=node-20?

 

[Brent W]

Do you mean: http://www.shottalk.com/misc/quick-navigation-menu?selected=node-20?

Not sure what you are asking? I am referring to not being able to use the lightbox popup when you click an image in my link I posted to navigate through the attached images. Disabling the add-on allows it to function correctly.

 

[rdn]

lightbox is working on my part.

 

[agison]

This breaks the lightbox pop up navigation for me. Disabling this product fixes it. Go to this post and try to navigate: http://www.shottalk.com/threads/first-round-of-2013.33818/#post-384901

Lightbox on your site works fine with me.

 

[sonnb]

He means the Next/Previous buttons are not shown up when he enabled this addon.

 

[Stemis]

After uninstall add-on guests still can view full image attachments without login. How to disable this?

 

[agison]

After uninstall add-on guests still can view full image attachments without login. How to disable this?

It may a user group permissions. You should change it.

 

[Stemis]

My fault. Images is attached in XenPorta Recent News block and that is a reason why guests can view full image.

 

[LondonDragon]

Hi guys, after installing this addon it sure makes images load a lot faster only issue I have is when you add the images as attachment at the footer the post, when you click on one of the thumbnails then it does not allow you to move to the next image, you need to close the popup and then click on the next, however if you add the thumbnails to the post, it then works fine, any ideas? thanks

 

[Brent W]

Hi guys, after installing this addon it sure makes images load a lot faster only issue I have is when you add the images as attachment at the footer the post, when you click on one of the thumbnails then it does not allow you to move to the next image, you need to close the popup and then click on the next, however if you add the thumbnails to the post, it then works fine, any ideas? thanks

I've experienced this as well

 

[agison]

Dinh Thanh updated [Tinhte] Image Attachment Optimization & CDN Support with a new update entry:

Bug fix

Fix missing previous/next buttons bug.

Read the rest of this update entry...

 

[LondonDragon]

Many thanks for sorting it out so quickly! now it flies once again and no issues with attachments

 

[webroxau]

Thank you, awesome mod!

I'm expecting to see a massivc drop in my server bandwidth from this mod. Being able to offload the attachments to CDN is something i've wanted to do ever since we converted to Xenforo.

 

[webroxau]

Hmmm .. is there a way to set cache-control max-age ?? It appears they are being set as max-age=0 so the images are not getting cached by the CDN. So every user that visits a page, the CDN is grabbing a copy of the file as the max-age is not allowing it to be cached by the CDN.

 

[Mouth]

Hmmm .. is there a way to set cache-control max-age ?? It appears they are being set as max-age=0 so the images are not getting cached by the CDN, so every user that visits a page, the CDN is grabbing a copy of the file as the max-age is not allowing it to be cached by the CDN.

Good pickup. max-age is the preferred method over expires, even better to use both.

Add

$this->_response->setHeader('Cache-Control', 'max-age=2592000', true);

to both
library/Tinhte/AttachImageOptimization/ViewPublic/Attachment/View.php
and
library/Tinhte/AttachImageOptimization/ViewPublic/Attachment/View304.php

 

[webroxau]

Good pickup. max-age is the preferred method over expires, even better to use both.

Add

$this->_response->setHeader('Cache-Control', 'max-age=2592000', true);

to both
library/Tinhte/AttachImageOptimization/ViewPublic/Attachment/View.php
and
library/Tinhte/AttachImageOptimization/ViewPublic/Attachment/View304.php

Cheers, will see how that goes.

Kind of defeats the purpose of using the CDN if its not actually caching anything.

 

[Mouth]

Kind of defeats the purpose of using the CDN if its not actually caching anything.

As you'll see in the .php it was never sending a max-age, so I don;t know where you were getting a max-age=0 from? Perhaps a non-compliant proxy that was defaulting?
In any case, setting an actual max-age is preferable.

 

[webroxau]

Yeah im not entirely sure. I first picked up on it when looking at the cache hits for the attachments and it was showing 100% not able to be cached. I'll look into it when I get some time.