- Fix unexpected additional user queries when threadmarks in the recent threadmarks are not from the thread starter
@Hobbes update Threadmarks to latest or redownload the version you had and re-upload it.
- Reduce unexpected extra queries when XF loads new replies via ajax
- Fix possible N+1 query behaviour when fetching various threadmark lists
- Fix double-encoding of caching which is suprisingly expensive
- Fix "new threadmarks" widget would not select any threadmarks if 'active conversations' and various thread options where selected.
- Add "all threads" filter to "new threadmarks" widget, please check widget configuration. When updating widget configuration a thread option must be explicitly selected to include post threadmarks.
- Avoid unexpected additional queries on replying to thread
[root@guiling forum]# php cmd.php xf-addon:upgrade SV/Threadmarks
Upgrading Threadmarks from 1.6.14 to 2.9.7...
Confirm upgrade? (y/n)y
Upgrading
In AbstractStatement.php line 228:
[XF\Db\DuplicateKeyException (1062)]
xf_sv_threadmark: MySQL query error [1062]: Duplicate entry '225770' for ke
y 'content_type_id'
Exception trace:
at /var/www/xf2_migrate/forum/src/XF/Db/AbstractStatement.php:228
XF\Db\AbstractStatement->getException() at /var/www/xf2_migrate/forum/src/XF/Db/Mysqli/Statement.php:196
XF\Db\Mysqli\Statement->getException() at /var/www/xf2_migrate/forum/src/XF/Db/Mysqli/Statement.php:77
XF\Db\Mysqli\Statement->execute() at /var/www/xf2_migrate/forum/src/XF/Db/AbstractAdapter.php:94
XF\Db\AbstractAdapter->query() at /var/www/xf2_migrate/forum/src/XF/Db/Schema/AbstractDdl.php:151
XF\Db\Schema\AbstractDdl->apply() at /var/www/xf2_migrate/forum/src/XF/Db/SchemaManager.php:149
XF\Db\SchemaManager->alterTable() at /var/www/xf2_migrate/forum/src/addons/SV/Threadmarks/Setup.php:34
SV\Threadmarks\Setup->installStep1() at /var/www/xf2_migrate/forum/src/addons/SV/Threadmarks/Setup.php:172
SV\Threadmarks\Setup->upgrade2000089Step1() at /var/www/xf2_migrate/forum/src/XF/AddOn/StepRunnerUpgradeTrait.php:122
SV\Threadmarks\Setup->upgradeStepRunner() at /var/www/xf2_migrate/forum/src/XF/AddOn/StepRunnerUpgradeTrait.php:71
SV\Threadmarks\Setup->upgrade() at /var/www/xf2_migrate/forum/src/XF/Cli/Command/AddOnActionTrait.php:109
XF\Cli\Command\AddOnSubAction->performAddOnAction() at /var/www/xf2_migrate/forum/src/XF/Cli/Command/AddOnSubAction.php:79
XF\Cli\Command\AddOnSubAction->execute() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Command/Command.php:255
Symfony\Component\Console\Command\Command->run() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:992
Symfony\Component\Console\Application->doRunCommand() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:255
Symfony\Component\Console\Application->doRun() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:148
Symfony\Component\Console\Application->run() at /var/www/xf2_migrate/forum/src/XF/Cli/Runner.php:109
XF\Cli\Runner->run() at /var/www/xf2_migrate/forum/cmd.php:15
xf:addon-sub-action [--k K] [--] <id> <action>
Should be fixed.Hello @Xon,
I would like to buy this add-on, but don't know what to do next. Can you please check it out?
View attachment 243909
This would happen if you've some how gotten two threadmarks on the one post. This really shouldn't happen, and will require some manual database editing to fix.I'm trying to upgrade from the old Threadmarks Pro after going from Xenforo 1.5 -> 2.2. On running the upgrade command, I get:
I can't make any particular sense of this. The content_type_id unique key it's trying to add is of two columns which don't exist in the old xf_sv_threadmarks table, so I'm not sure how anything about the old data could break it.Code:[root@guiling forum]# php cmd.php xf-addon:upgrade SV/Threadmarks Upgrading Threadmarks from 1.6.14 to 2.9.7... Confirm upgrade? (y/n)y Upgrading In AbstractStatement.php line 228: [XF\Db\DuplicateKeyException (1062)] xf_sv_threadmark: MySQL query error [1062]: Duplicate entry '225770' for ke y 'content_type_id' Exception trace: at /var/www/xf2_migrate/forum/src/XF/Db/AbstractStatement.php:228 XF\Db\AbstractStatement->getException() at /var/www/xf2_migrate/forum/src/XF/Db/Mysqli/Statement.php:196 XF\Db\Mysqli\Statement->getException() at /var/www/xf2_migrate/forum/src/XF/Db/Mysqli/Statement.php:77 XF\Db\Mysqli\Statement->execute() at /var/www/xf2_migrate/forum/src/XF/Db/AbstractAdapter.php:94 XF\Db\AbstractAdapter->query() at /var/www/xf2_migrate/forum/src/XF/Db/Schema/AbstractDdl.php:151 XF\Db\Schema\AbstractDdl->apply() at /var/www/xf2_migrate/forum/src/XF/Db/SchemaManager.php:149 XF\Db\SchemaManager->alterTable() at /var/www/xf2_migrate/forum/src/addons/SV/Threadmarks/Setup.php:34 SV\Threadmarks\Setup->installStep1() at /var/www/xf2_migrate/forum/src/addons/SV/Threadmarks/Setup.php:172 SV\Threadmarks\Setup->upgrade2000089Step1() at /var/www/xf2_migrate/forum/src/XF/AddOn/StepRunnerUpgradeTrait.php:122 SV\Threadmarks\Setup->upgradeStepRunner() at /var/www/xf2_migrate/forum/src/XF/AddOn/StepRunnerUpgradeTrait.php:71 SV\Threadmarks\Setup->upgrade() at /var/www/xf2_migrate/forum/src/XF/Cli/Command/AddOnActionTrait.php:109 XF\Cli\Command\AddOnSubAction->performAddOnAction() at /var/www/xf2_migrate/forum/src/XF/Cli/Command/AddOnSubAction.php:79 XF\Cli\Command\AddOnSubAction->execute() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Command/Command.php:255 Symfony\Component\Console\Command\Command->run() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:992 Symfony\Component\Console\Application->doRunCommand() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:255 Symfony\Component\Console\Application->doRun() at /var/www/xf2_migrate/forum/src/vendor/symfony/console/Application.php:148 Symfony\Component\Console\Application->run() at /var/www/xf2_migrate/forum/src/XF/Cli/Runner.php:109 XF\Cli\Runner->run() at /var/www/xf2_migrate/forum/cmd.php:15 xf:addon-sub-action [--k K] [--] <id> <action>
select *
from xf_sv_threadmark
where content_id in (select content_id from xf_sv_threadmark group by content_id having count(*) > 1);
ok, however fyi, in this case, the category does have threadmarks...but link still not workThe "sort threadmarks" link looks to be hard-coded to the first threadmark category even if it doesn't have items. Will look into fixing that
- Fix unexpected N+1 queries when embedding the threadmark index into thread
- Fix using threadmark username for the post username in news feed
- Fix incorrect threadmark category rss link generation
- If the user can edit/add an icon, add a quick link rather than requiring going through editing the threadmark index
- Display watch count and 'recent' reader counts, display is controller by new style properties ("Show watch count" and "Show recent reader count") and recentcy by...
thats under navigation in admin cpJust started using it and don't see an option yet, so how do you move the New Threadmarks link to be third on the list of What's New nav item ?
It is currently above New Posts and New Profile Posts.
Thanks I saw that, but the What's New page still shows the New Threadmark results on top.thats under navigation in admin cp
- Work-around case where threads with only non-visible threadmarks do not show delete/moderated placeholders
- Adjust flood timer for editing threadmark indexes
- Attempt to prevent duplicate entry exceptions when adding threadmarks, includes adding a small flood timer and additional row locking.
- Fix that non-visible threadmarks could potentially add css marking posts as having a threadmark
- Triggers a rebuild of threads/conversations to correct cached configuration...
We use essential cookies to make this site work, and optional cookies to enhance your experience.