Fixed 'Post new profile posts'

[Jeremy P]

Setting this permission to 'Never' for any user results in the update status box being removed from their profile page and user navigation dropdown, but the 'Update Status' box still appears in their User CP.

I think it should be wrapped in a condition so we could effectively disable users from updating their statuses with this permission.

 

[ragtek]

IMHO the complete part is buggy.

1. the tab is always shown. there's no check if somebody can see this

<li><a href="{$requestPaths.requestUri}#profilePosts">{xen:phrase profile_posts}</a></li>

should be

<xen:if is="{$canViewProfilePosts}">
                    <li><a href="{$requestPaths.requestUri}#profilePosts">{xen:phrase profile_posts}</a></li>
                    </xen:if>

2. you show also the tab content, and if somebody is not allowed to see it, he gets

<div id="NoProfilePosts">{xen:phrase there_no_messages_on_xs_profile_yet, 'name={$user.username}'}</div>

But that's not true. There are maybe profile posts,so he shouldn't get the false message.

IMHO the if condition should be fixed and surround the complete <li>...</li>

Steps to reproduce:

 

[erich37]

http://xenforo.com/community/threads/duplicate-unconfirmed-user-can-update-status.18488/#post-243981

 

[Jeremy P]

http://xenforo.com/community/threads/duplicate-unconfirmed-user-can-update-status.18488/#post-243981

Considering that doesn't seem to be tied to permissions at all you'll probably want to file a separate bug report.

 

[Mike]

The main reported issue has been fixed (actually fixed a while ago). It may be reasonable to remove the profile posts tab if there's no permission to it, but that is separate.