Fixed Pickaday previous/next buttons not picking up text color on dark styles

[Snog]

Affected version

2.1

The color used for the previous/next buttons in a pickaday box are not being controlled by any particular color.



This can be corrected by adding the color to the core_pickaday.less template:

.pika-prev,
.pika-next
{
    display: block;
    cursor: pointer;
    position: relative;
    outline: none;
    background: none;
    border: 0;
    padding: 0;
    width: 20px;
    height: 30px;
    white-space: nowrap;
    overflow: hidden;
    opacity: .5;
    font-size: 0;
    color: @pd-day-color;
....

 

[marquisite]

Nice catch! The date-range related classes (e.g. is-inrange) in the same pikaday template contain hardcoded hex codes, too. While XenForo doesn't support date ranges out of the box, it seems a shame to not have these classes use style property values ... for any add-ons or custom code which use this part of the date picker.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.1).

Change log:

Fix next/prev month button color in the date picker and allow date ranges to pull colors from the style properties.

Any changes made as a result of this issue being resolved may not be rolled out here until later.

 

[marquisite]

Awesome!

Possibly worth marking the style properties for date ranges suggestion as Implemented?

Implemented - Convert core_pikaday.less hardcoded CSS hex colours to use @xf-* style properties.

Towards the end of the core_pikaday.less master style template, there are some style rules which contain hardcoded values for font colour, background, etc. This relates to .is-inrange .pika-button, .is-startrange .pika-button and .is-endrange .pika-button. While I don't believe XF 2.0...

xenforo.com