Fixed Error when getMetadataKey return array

[guiltar]

Class XenForo_Search_SourceHandler_MySqlFt has method

    public function insertIntoIndex($contentType, $contentId, $title, $message, $itemDate, $userId, $discussionId = 0, array $metadata = array())
    {
        $metadataPieces = array(
            $this->getMetadataKey('user', $userId),
            $this->getMetadataKey('content', $contentType)
        );
        foreach ($metadata AS $metadataKey => $value)
        {
            $metadataPieces[] = $this->getMetadataKey($metadataKey, $value);
        }
 
        $db = $this->_getDb();
        $row = '(' . $db->quote($contentType) . ', ' . $db->quote(intval($contentId))
            . ', ' . $db->quote($title) . ', ' . $db->quote($message)
            . ', ' . $db->quote(implode(' ', $metadataPieces))
            . ', ' . $db->quote(intval($itemDate)) . ', ' . $db->quote(intval($userId))
            . ', ' . $db->quote(intval($discussionId)) . ')';

    * @return string|array String if $value was a string, array if $value was an array
    */
    public function getMetadataKey($keyName, $value)
    {

Notice that getMetadataKey can return array and this causes error while imploding $metadataPieces.

 

[Yoskaldyr]

simple fix:

        foreach ($metadata AS $metadataKey => $value)
        {
            $metadataPieces[] = $this->getMetadataKey($metadataKey, $value);
        }

replace with

        foreach ($metadata AS $metadataKey => $value)
        {
            $metadataPiece = $this->getMetadataKey($metadataKey, $value);
            $metadataPieces[] = (is_array($metadataPiece)) ? implode(' ', $metadataPiece) : $metadataPiece;
        }

 

[guiltar]

Or such a way

        foreach ($metadata AS $metadataKey => $value)
        {
            $metadataPiece = $this->getMetadataKey($metadataKey, $value);
            $metadataPieces = array_merge($metadataPieces, is_array($metadataPiece) ? $metadataPiece : array($metadataPiece));
        }

 

[Mike]

Fixed, thanks.

 

[Pepelac]

Fixed, but with small problem: undefined variable $metaDataPieces at line 53.

Just rename it to $metadataPieces

 

[Vincent]

Fixed, but with small problem: undefined variable $metaDataPieces at line 53.

Just rename it to $metadataPieces

Create a new thread for this, else the devs won't notice after their time away.

 

[Jake Bunce]

Moved back to bugs. Thanks.

 

[Mike]

Fixed... properly this time.