Alert Improvements by Xon

Alert Improvements by Xon 2.10.13

No permission to download
Overview FAQ Updates (68) Reviews (9) History Discussion
Getting thousands of these on PHP 8.0+

Rebuilt master data, it does not work. Looks like is is calling 'svAlertsImprov_macros' instead of 'svAlertImprov_macros'

1696390040688.webp
 
Xon updated Alert Improvements by Xon with a new update entry:

2.10.11 - Minor feature update

  • Add explain text to the "Use custom" value for "Alerting Preferences" per-user option
  • Add "[Alert Improvements] Can customize advanced alert preferences" permission to control is a user can change the following per-user preferences: "Alerts page options"/"Alert pop-up options"/"Alerts summarize threshold"
    Permission granted to Registered user group by default
Click to expand...

Read the rest of this update entry...
 
Please ensure the template svAlertImprov_macros doesn't have customizations which remove the alerting_preferences macro. You may need to check multiple styles depending on how your theming is setup.
 
I am not sure what is going on, but we are getting random errors while marking alerts as read.

And now getting this -

1696590014189.png


Code: 
#0 [internal function]: XF\Template\Templater->handleTemplateError(2, '[E_WARNING] chm...', '/var/www/fastus...', 368)
#1 src/vendor/league/flysystem/src/Adapter/Local.php(368): chmod('/var/www/fastus...', 420)
#2 src/XF/LocalFsAdapter.php(73): League\Flysystem\Adapter\Local->setVisibility('templates/l0/s4...', 'public')
#3 src/vendor/league/flysystem/src/Adapter/Local.php(210): XF\LocalFsAdapter->setVisibility('templates/l0/s4...', 'public')
#4 src/vendor/league/flysystem/src/Filesystem.php(99): League\Flysystem\Adapter\Local->update('templates/l0/s4...', '<?php
// FROM H...', Object(League\Flysystem\Config))
#5 [internal function]: League\Flysystem\Filesystem->put('templates/l0/s4...', '<?php
// FROM H...', Object(League\Flysystem\Config))
#6 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(431): call_user_func_array('League\\Flysyste...', Array)
#7 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(395): League\Flysystem\EventableFilesystem\EventableFilesystem->callFilesystemMethod('put', Array)
#8 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(57): League\Flysystem\EventableFilesystem\EventableFilesystem->delegateMethodCall('put', Array)
#9 src/vendor/league/flysystem/src/MountManager.php(597): League\Flysystem\EventableFilesystem\EventableFilesystem->put('templates/l0/s4...', '<?php
// FROM H...', Array)
#10 src/XF/Util/File.php(225): League\Flysystem\MountManager->put('templates/l0/s4...', '<?php
// FROM H...', Array)
#11 src/XF/Service/Template/Compile.php(146): XF\Util\File::writeToAbstractedPath('code-cache://te...', '<?php
// FROM H...')
#12 src/XF/Service/Template/Compile.php(43): XF\Service\Template\Compile->writeCompiled(Object(XF\Entity\Template), 'code-cache://te...', 'return array(
'...')
#13 src/XF/Entity/Template.php(435): XF\Service\Template\Compile->recompile(Object(XF\Entity\Template))
#14 src/XF/Mvc/Entity/Entity.php(1277): XF\Entity\Template->_postSave()
#15 src/XF/DevelopmentOutput/Template.php(103): XF\Mvc\Entity\Entity->save()
#16 src/XF/DevelopmentOutput/Template.php(207): XF\DevelopmentOutput\Template->import('public:svAlertI...', 'SV/AlertImprove...', '<div>
<xf:forea...', Array, Array)
#17 src/XF/Template/Templater.php(684): XF\DevelopmentOutput\Template->watchTemplate(Object(SV\WarningImprovements\XF\Template\Templater), 'public', 'svAlertImprov_a...')
#18 src/XF/Template/Templater.php(1621): XF\Template\Templater->getTemplateData('public', 'svAlertImprov_a...')
#19 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('svAlertImprov_a...', Array)
#20 src/XF/Mvc/Renderer/Json.php(86): XF\Template\Template->render()
#21 src/XF/Mvc/Renderer/Json.php(70): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Account\\Aler...', 'public:svAlertI...', Array)
#22 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Json->renderView('XF:Account\\Aler...', 'public:svAlertI...', Array)
#23 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#24 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#25 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#26 src/XF/App.php(2487): XF\Mvc\Dispatcher->run()
#27 src/XF.php(524): XF\App->run()
#28 index.php(20): XF::runApp('XF\\Pub\\App')
#29 {main}
 
noxa said:
I am not sure what is going on, but we are getting random errors while marking alerts as read.

And now getting this -

View attachment 292094


Code: 
#0 [internal function]: XF\Template\Templater->handleTemplateError(2, '[E_WARNING] chm...', '/var/www/fastus...', 368)
#1 src/vendor/league/flysystem/src/Adapter/Local.php(368): chmod('/var/www/fastus...', 420)
#2 src/XF/LocalFsAdapter.php(73): League\Flysystem\Adapter\Local->setVisibility('templates/l0/s4...', 'public')
#3 src/vendor/league/flysystem/src/Adapter/Local.php(210): XF\LocalFsAdapter->setVisibility('templates/l0/s4...', 'public')
#4 src/vendor/league/flysystem/src/Filesystem.php(99): League\Flysystem\Adapter\Local->update('templates/l0/s4...', '<?php
// FROM H...', Object(League\Flysystem\Config))
#5 [internal function]: League\Flysystem\Filesystem->put('templates/l0/s4...', '<?php
// FROM H...', Object(League\Flysystem\Config))
#6 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(431): call_user_func_array('League\\Flysyste...', Array)
#7 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(395): League\Flysystem\EventableFilesystem\EventableFilesystem->callFilesystemMethod('put', Array)
#8 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(57): League\Flysystem\EventableFilesystem\EventableFilesystem->delegateMethodCall('put', Array)
#9 src/vendor/league/flysystem/src/MountManager.php(597): League\Flysystem\EventableFilesystem\EventableFilesystem->put('templates/l0/s4...', '<?php
// FROM H...', Array)
#10 src/XF/Util/File.php(225): League\Flysystem\MountManager->put('templates/l0/s4...', '<?php
// FROM H...', Array)
#11 src/XF/Service/Template/Compile.php(146): XF\Util\File::writeToAbstractedPath('code-cache://te...', '<?php
// FROM H...')
#12 src/XF/Service/Template/Compile.php(43): XF\Service\Template\Compile->writeCompiled(Object(XF\Entity\Template), 'code-cache://te...', 'return array(
'...')
#13 src/XF/Entity/Template.php(435): XF\Service\Template\Compile->recompile(Object(XF\Entity\Template))
#14 src/XF/Mvc/Entity/Entity.php(1277): XF\Entity\Template->_postSave()
#15 src/XF/DevelopmentOutput/Template.php(103): XF\Mvc\Entity\Entity->save()
#16 src/XF/DevelopmentOutput/Template.php(207): XF\DevelopmentOutput\Template->import('public:svAlertI...', 'SV/AlertImprove...', '<div>
<xf:forea...', Array, Array)
#17 src/XF/Template/Templater.php(684): XF\DevelopmentOutput\Template->watchTemplate(Object(SV\WarningImprovements\XF\Template\Templater), 'public', 'svAlertImprov_a...')
#18 src/XF/Template/Templater.php(1621): XF\Template\Templater->getTemplateData('public', 'svAlertImprov_a...')
#19 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('svAlertImprov_a...', Array)
#20 src/XF/Mvc/Renderer/Json.php(86): XF\Template\Template->render()
#21 src/XF/Mvc/Renderer/Json.php(70): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Account\\Aler...', 'public:svAlertI...', Array)
#22 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Json->renderView('XF:Account\\Aler...', 'public:svAlertI...', Array)
#23 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#24 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#25 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#26 src/XF/App.php(2487): XF\Mvc\Dispatcher->run()
#27 src/XF.php(524): XF\App->run()
#28 index.php(20): XF::runApp('XF\\Pub\\App')
#29 {main}
Click to expand...
This isn't related to any of my add-ons, but XenForo can't write to the internal_data/code_cache/ folder.
 
Xon said:
Please ensure the template svAlertImprov_macros doesn't have customizations which remove the alerting_preferences macro. You may need to check multiple styles depending on how your theming is setup.
Click to expand...
I have double-checked, nothing customization there. We get this error while going to the user preference page.

1696618227240.png

I have found the code on a template modification.

1696618468569.webp
 
Just to be clear, it is asking for a macro called alerting_preference that is not present inside svAlertImprove_macros.

I feel like it has been removed or renamed, and the old forum giving errors after the upgrade. Could you please confirm?
 
We are getting more errors while editing users. Really not sure what is going on. I have rebuilt the addon a couple of times.

1696619646244.webp
 
My apologies for all these posts. We are using everything latest with PHP 8.1. We can no longer update any user from the admin area. It gives this error -

1696637866853.webp

1696637879956.webp
 
Do you have (or had) development enabled and have _output directory in any add-on? This is known footgun, especially when mixed with the Web installer, and is known to basically break add-ons like this.

Remove this line from src/config.php:
PHP: 
$config['development']['enabled'] = true;
Remove this folder:
Code: 
rm -rf src/addons/SV/AlertImprovements/_output
Rebuild the add-on:
Code: 
php cmd.php xf-addon:rebuild SV/AlertImprovements
 
I enabled this addon after the recent updates and the issue I was having with the alerts being marked as read regardless of the settings is fixed. Thanks!

Xon said:
Some of these are controlled from the "Alert Improvements" style property options. Make sure the "Show recent alert icon on alert" and "Show read alert icon on alert" style property options are set, and the rest are defaults.

Otherwise it is like the "Alert summarization" feature is handling multiple replies to a given post now, there is currently no options to enable/disable this support.
Click to expand...
I enabled both of these but only the "Recent alert icon" works. The "Unread alert icon" doesn't do anything.

I tried changing it to fa fa-star instead of fa fa-star-exclamation but that had no impact. I also disabled Recent alert icon and left Unread alert icon enabled, and it still doesn't show.
 
I cant use your addon and the one from AndyB at the same time.
You may check this out together with him, please?

xenforo.com

Remove notification options [Paid]

AndyB submitted a new resource: Remove notification options - Removes notification options in account preferences. Premium upgrade: This XF2 add-on along with the entire collection can be purchased for $35.00 USD. Your Premium upgrade will allow you to download as many XF2 add-ons as you like...
xenforo.com xenforo.com
 
Robert9 said:
I cant use your addon and the one from AndyB at the same time.
You may check this out together with him, please?

xenforo.com

Remove notification options [Paid]

AndyB submitted a new resource: Remove notification options - Removes notification options in account preferences. Premium upgrade: This XF2 add-on along with the entire collection can be purchased for $35.00 USD. Your Premium upgrade will allow you to download as many XF2 add-ons as you like...
xenforo.com xenforo.com
Click to expand...
There isn't really any point of using that add-on with this one. It introduces a vastly simplified alert preferences by default and a permission to disable the other alerting option this add-on ads.

Finally, that is a paid add-on which I don't have access to.
 
This is your choice, I was just friendly to tell both programmers that their add-ons don't fit together. Probably it is the template modification, i will look for it tonight.
 
You must log in or register to reply here.

Similar threads

N
Conversation Improvements by Xon - FRENCH translation
Replies
2
Views
538
Ozzy47
Ozzy47
N
Report Improvements by Xon - FRENCH translation
Replies
4
Views
534
Ozzy47
Ozzy47
N
Warning Improvements by Xon - FRENCH translation
Replies
3
Views
555
Ozzy47
Ozzy47
N
User Mentions Improvements by Xon - FRENCH translation
Replies
2
Views
520
Ozzy47
Ozzy47
N
Search Improvements by Xon - FRENCH translation
Replies
6
Views
651
Ozzy47
Ozzy47
Top Bottom