I was setting up an XF2.3.7 site and someone else changed the option to allow something and overwrote the default. Apologies!
But not allowing webp attachments when image optimization forces webp attachments is definitely on the confusing side
Webp should be an allowed attachment extension by default, so when image optimization is enabled attachment copy & paste doesn't break with a rather unfriendly error message (the actual image type isn't reported)
The generateEmailData function doesn't wrap a try/finally around the handling of the setLanguage calls, meaning if the code inside this method throws an exception the global language may have changed unexpectedly.
This matters as by default job.php will execute multiple jobs via runJobInternal...
Can you try rebuilding the MultiPrefix add-on?
While this add-on does add the sv_default_prefix_ids field to the XF\Entity\Forum class, Snog/AdvancedForms has explicit support for this add-on. You might need to update it
Removing the xf_addon and xf_user join from the alert query is actually a fairly noticable performance improvement on sites with super-large number of alerts.
My Alert Improvements add-on does this...
As long as the versionId never goes backwards; XF's outdated template detection works as expected and phrases work too.
It is part of the reason I set a unix-like timestamp as the version-id for my add-ons instead a integer encoded copy of the version string. I've got a CLI clamp-versions...
Require StandardLib v1.22.0+
Fix 2x image would be set as a duplicate of the overridden image url
Fix XenBase styles would duplicate the mobile logo depending on configuration
Fix optional selectable logo attributes could override style image urls to empty values
Improve XF Cloud compatibility...
There is only one feature that _metadata.json enables that isn't possible otherwise (vs clearing dangling references & importing _output); and that is tracking if the "cache global" flag has been set for a phrase.
Except phrase groups makes the "cache global" flag redundant. Phrase groups...
Committing _metadata.json causes endless merge conflicts, the format is practically made to cause issues. Plus it causes endless pointless churn which makes git change logs harder to work with
IMO it just isn't needed if you include a few extra CLI commands.
I've got a...
Touching the payment provider callback URL via GET causes an internal server error instead of the silently doing nothing.
An exception occurred: [ErrorException] [E_WARNING] Undefined array key "object" in src/XF/Payment/Stripe.php on line 689
XF::handlePhpError() in src/XF/Payment/Stripe.php...