Recent content by MilkyMeda

The quote button (replynoquote) does not work when injected after the page load. Reproduce steps: Post a thread. Post a message. The message will be auto-injected to the current page. Try to quote the newly injected message, it won't work. The page must be reloaded in order for the JS...

Hi, copy to clipboard button sends the message when pressed in preview mode. See here.

A possible race condition: XF\Db\DuplicateKeyException: MySQL query error [1062]: Duplicate entry 'multiple_account-525343' for key 'content_type_content_id' src/XF/Db/AbstractStatement.php:230 Stack trace INSERT INTO `xf_report` (`content_type`, `content_id`, `content_user_id`...

Error: Call to a member function hydrateRelation() on null src/addons/SV/ReportImprovements/Repository/ReportQueue.php:83 Stack trace #0 src/addons/SV/ReportImprovements/XF/Pub/Controller/Report.php(125)...

Duh... I guess that's why bug fixing should include retroactive correction.

It doesn't work with the list attribute:

On a busy forum with a very busy alert table -around 8m records- hourly cron task fails due to memory exhaustion. The responsible part of the task is the alert pruning. The memory usage easily exceeds 256 MB which is the limit I use which is not low. I was able to overcome this only by using...

Yes, there is a code event for that. You might want to take a look at code event listeners. You can also extend the related entity class's _preSave() method but you should use code event listeners as much as possible.

Valid point but trophies can be deleted and be removed from the users from the ACP anyway. I can remove the trophy and add it again to get what I want :P Since there are so many, it could be useful to let the rebuild job take care of them all.

I can see that. I wonder the logical reason behind that decision if there is any. We don't count the messages in some forums any longer and the trophies are still there. Newcomers are confused :unsure:

Is this deliberate? src/XF/Repository/Trophy.php:63 foreach ($trophies AS $trophy) { if (isset($userTrophies[$user->user_id . '-' . $trophy->trophy_id])) { continue; //But the criteria is met? } $userCriteria =...

ParseError: syntax error, unexpected token "\" src/addons/SV/WarningImprovements/XF/Service/User/ContentChange.php:54

I'm on the side of approving pre-reg action automatically whenever the user is in valid state. Email confirmation bypass is not the same as pre-reg action bypass. Pre-reg action bypass basically ignores their contribution to the community. It's the only reason why they signed up in the first...

When a user with pre-reg action gets rejected, the pre-reg action doesn't get deleted. If it doesn't get deleted immediately, it could be useful later on when they get approved by an admin via admin panel if the rejected user log has been reviewed. Saying that I could move every rejected user...

That would cause titles longer than 149 characters to be shortened to 149 characters.