• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Unable to spam clean threads which are already in the designated spam cleaner forum

Stuart Wright

Well-known member
#1
Not a serious bug, but a PITA anyway.
Sometimes moderators (none of whom have permission to spam clean) come across spam and helpfully report it and move it to the spam forum. We consider it important to remove spam from public view ASAP which is why we have instructed them to do this.
However, when an admin (the only people with permission to spam clean) comes along to properly clean the account up, they can't because the thread is already in the spam forum and trying to clean it causes an error.
It's a pain to have to move the thread out and then spam clean it.
Better if the spam cleaner doesn't try to move the thread if it's already in the spam forum.
Thanks
 

Chris D

XenForo developer
Staff member
#3
What's the error you get when they try and spam clean? There's no reason it shouldn't work the way you're wanting to do it.
 

Mike

XenForo developer
Staff member
#4
It says the threads are already in the selected forum -- it actually happens here every so often with a race condition. Just forgot about it.
 

Stuart Wright

Well-known member
#5
What do you mean by "spam forum"? Is that just a hidden forum you've created or something specific to an addon?
The spam cleaner can be set up to move spammy threads to a designated 'spam' forum, and this is what we do.
We keep all the crap in one place so that we can identify spammers if they return.
Except the spam cleaner presumably fires off the thread move function which fails because we're trying to move a thread to a forum where it is already located.

So it's on the 'to do' list, Mike?
 

Harpers Tate

Well-known member
#7
The spam cleaner is set so as to move all the user's threads to a designated forum (the "Spam forum"). If all of the User's threads are already in the designated forum then any attempt to spam clean that user (wherever it's initiated) errors as Mike describes. Once it errors, it does not proceed to do all the other tasks, like banning the user, EMailing them, detecting IPs and so on. So we have to start over, this time unchecking the box to move threads, in order for it to work. Which is tedious.

I'd suggest that the message (that all the user's posts are already in there) either
a) isn't really needed, as that's what we intended to do anyway or
b) if it's really essential (which I'm not at all convinced by) it should be a dismissable warning which will allow the process to proceed with its other steps.
 

Mike

XenForo developer
Staff member
#8
This error has been suppressed. It's useful when it's a human moving the threads because it often means that they tried to move them to the wrong forum but it doesn't make sense here.