1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Twitter Button URL

Discussion in 'Resolved Bug Reports' started by Wootalyzer, Feb 4, 2011.

  1. Wootalyzer

    Wootalyzer Active Member

    For consistancies sake (as well as people using the sidebar_share_page template externally), the twitter share button should probably have a data-url parameter set to {$url}. The facebook link already has this. :)
  2. Mike

    Mike XenForo Developer Staff Member

    Looks more like a bug to me, so fixed now.
  3. Kier

    Kier XenForo Developer Staff Member

    Actually it was by design - the Facebook button requires that the URL is explicitly set, while the Tweet button will pick up the page URL if nothing else is specified. On the share_page template we set data-url for the Tweet button to be the first page link, regardless of what page you are actually viewing, so everything was working as designed, but adding data-url won't do anything bad.

Share This Page