[TRN] Discussion Preview [Deleted]

After upgrading to the new version, You are advised to immediately review the settings.

As before, should you encounter any issues or have any questions, just post here and I will act promptly.
 
Last edited:
Man you work fast! Another update already!

I upgraded and the first/last post settings seem to be working like a charm, so I'm over the moon with this update (y)

I tested the other settings and "Don't remove URL's" doesn't seem to be working properly, it functions the same as "Remove URLs but keep the "Website" text" and just leaves the text...

url-removal-issue.webp

I also noticed a couple of very minor things. They don't affect function, they're just cosmetic really...

1 - "first_post" needs a phrase
2 - The watched threads "explain" is repeated beneath the url options

Screen Shot 2016-03-07 at 14.00.41.webp

Thanks again for the super fast update :)
 
RichardKYA said:
Man you work fast! Another update already!

I upgraded and the first/last post settings seem to be working like a charm, so I'm over the moon with this update (y)

I tested the other settings and "Don't remove URL's" doesn't seem to be working properly, it functions the same as "Remove URLs but keep the "Website" text" and just leaves the text...

View attachment 130072

I also noticed a couple of very minor things. They don't affect function, they're just cosmetic really...

1 - "first_post" needs a phrase
2 - The watched threads "explain" is repeated beneath the url options

View attachment 130073

Thanks again for the super fast update :)
Click to expand...

Thanks @RichardKYA :)

I could not reproduce the URL issue here. However I found that if I put several URLS after each other, my replacement was "greedy" and ate what was between them. I've fixed that now. I've also fixed the 2 minor things that you told me about. ;)

Do You have time to test the modifications at your site? (You should be able to redownload)

I've tested the URL using the following message BBCode:
Code: 
Just a test. [URL]http://www.site.se[/URL] blah [URL='http://site.se']Site[/URL] abc

Thanks!!!
 
Hi @farang

I updated to 1.3.2 and I'm still having the same issue with the urls, unless I'm understanding what it does incorrectly?

Using your bbcode above, the result is this...

Code: 
[URL]http://www.site.se[/URL]

...gets displayed as...

Code: 
http://www.site.se

...which I believe is correct, but this...

Code: 
[URL='http://site.se']Site[/URL]

...gets displayed as...

Code: 
Site

...which I believe is incorrect? Should that not also be displayed as the url? (http://site.se) Or am I getting that wrong?

Thank you for another quick update :)
 
@RichardKYA

Below You can see how it's supposed to work. Using the following BBCode in all examples below:
Code: 
Just a test. [URL]http://www.site.se[/URL] blah [URL='http://site.se']Site[/URL] abc

0) Don't remove URLs:
Code: 
Just a test. http://www.site.se blah Site abc

1) Remove URLs but keep the "Website" text
Code: 
Just a test. blah Site abc

2) Remove URLs completely
Code: 
Just a test. blah abc

Note that in all cases above, there is intentionally no <a> tag in the preview text. Nothing gets clickable. Actually all BBCodes are stripped from the preview text because allowing BBCode would cause a lot of unexpected results and it would look quite ugly.

Just because it works as described above doesn't mean that it's the best way to do it. I need to listen to You all what are your preferences. I'm also open for any suggestions how to change the option texts to make it more clear and less obscure. :)

Thanks a lot for your help @RichardKYA , it's very appreciated.
 
Ah, OK, it's working as designed - my bad, I just misunderstood what it's meant to do, with "Don't remove URLs", I thought the inner url would remain and the text would be removed lol

Anyway, just to help, I thought I would take a few minutes and mock up some of the labels, explanations, etc. I thought I would change "Preview posts" to "Discussion Preview" to help tie it in with the "Discussion Preview Length", so that it helps users understand what the options are linked to...

Screen Shot 2016-03-07 at 18.38.11.webp

It's there for you to use if you like any of it :)

Thank you (y)
 
farang said:
@RichardKYA

Below You can see how it's supposed to work. Using the following BBCode in all examples below:
Code: 
Just a test. [URL]http://www.site.se[/URL] blah [URL='http://site.se']Site[/URL] abc

0) Don't remove URLs:
Code: 
Just a test. http://www.site.se blah Site abc

1) Remove URLs but keep the "Website" text
Code: 
Just a test. blah Site abc

2) Remove URLs completely
Code: 
Just a test. blah abc

Note that in all cases above, there is intentionally no <a> tag in the preview text. Nothing gets clickable. Actually all BBCodes are stripped from the preview text because allowing BBCode would cause a lot of unexpected results and it would look quite ugly.

Just because it works as described above doesn't mean that it's the best way to do it. I need to listen to You all what are your preferences. I'm also open for any suggestions how to change the option texts to make it more clear and less obscure. :)

Thanks a lot for your help @RichardKYA , it's very appreciated.
Click to expand...


Could there be an option to make the link clickable from the preview text?
 
RichardKYA said:
Ah, OK, it's working as designed - my bad, I just misunderstood what it's meant to do, with "Don't remove URLs", I thought the inner url would remain and the text would be removed lol

Anyway, just to help, I thought I would take a few minutes and mock up some of the labels, explanations, etc. I thought I would change "Preview posts" to "Discussion Preview" to help tie it in with the "Discussion Preview Length", so that it helps users understand what the options are linked to...

View attachment 130090

It's there for you to use if you like any of it :)

Thank you (y)
Click to expand...

Wow that's way better than before @RichardKYA. I will adopt your suggestions into the next version. You've been very helpful and Your work is really appreciated. Thanks!

racersimage said:
Could there be an option to make the link clickable from the preview text?
Click to expand...

Thanks for the suggestion @racersimage , I will try to implement that in the next version.

(y)
 
Hello Sir. how about if the post contain only picture/s? it will show that picture/s too?
 
rafass said:
Hello Sir. how about if the post contain only picture/s? it will show that picture/s too?
Click to expand...

Hello @rafass

It can probably be done but any picture should probably be miniaturized first. It would require some additional work but I can put it on the "wish list" if you think it's a good idea?
 
I love it. in fact, that will be a great feature. you know, people love pictures.
n1.webp n2.webp n4.webp n3.webp
miniatures that open in overlay. that would be really cool (y)
 
Thanks guys for all suggestions. I've implemented most of it and I will soon have a look into if I can allow pictures as @rafass suggested.

This add-on has evolved a lot since it was first released and the options has multiplied. There are now so many options that it has outgrown the XF Option Group "Threads, Discussions and Conversations".

I felt it was time to put all the options in it's on option group and allowing even more features in the future.

@RichardKYA has suggested much better and more clear titles and help texts for the options. I realize that the name of the plugin also needs to change to better reflect what it's doing. It offers a preview of the discussion so it should be "[fgX] Discussion Preview" (as opposed to the old name [fgX] Post Preview)

So I now have a version 2.0.0 to be released soon.
  • Name changed to [fgX] Discussion Preview
  • Incorporated @RichardKYA's suggested nomenclature.
  • Implemented another option for URLs as suggested by @racersimage allowing clickable URLs in the preview text.
  • All options now in it's own option group.
  • New option for Discussion preview length (Now separated from the XF settings for tooltip preview length)
I've been testing it as much as possible on my own system and it has no known issues. I need someone to test it for me before I release it. (The add-on download link that You have received by e-mail now allows you to download both files, addon-DiscussionPreview_v2.0.0.zip and addon-PostPreview_v1.3.2.zip). You'd need to uninstall the old version of [fgX] Post Preview before installing version 2.0.0. Thanks!!! Please leave some feedback here if You try version 2.0.0. (y)
 
Last edited:
I'm installing 2.0.0 right now so I will test things out and let you know how it goes, also I just had another idea...

"Discussion Preview in Conversation List"

With the same options "Disabled", "First Post", "Last Post"

Just another idea to keep you busy ;)
 
Hi @farang,

I've had a little play around and everything seems to be working well apart from in some cases, clickable links end up with "http://http://........"

Screen Shot 2016-03-08 at 14.26.29.webp

Other than that, it's looking great (y)

Thank you for another super fast update :)
 
This is the whole post, but it only happens to the one with a placeholder...

Code: 
Just a test. [URL]http://www.site.se[/URL] blah [URL='http://site.se']Site[/URL] abc
 
farang updated [fgX] Discussion Preview with a new update entry:

Version 2.0.2 released (Please read the upgrade instructions below)

New features in version 2.0.2
  • Name changed to [fgX] Discussion Preview
  • Incorporated @RichardKYA's suggested nomenclature.
  • Implemented another option for URLs as suggested by @racersimage allowing clickable URLs in the preview text.
  • All options now in it's own option group.
  • New option for Discussion preview length (Now separated from the XF settings for tooltip preview length)
The old version is named [fgX]...
Click to expand...

Read the rest of this update entry...
 
You must log in or register to reply here.

Similar threads

Ozzy47
[OzzModz] Article Preview Message Custom Field Replacement [Paid]
Replies
0
Views
326
Ozzy47
Ozzy47
justin kane
  • Question Question
XF 2.2 After enabling Friendly URL's Thread/Discussion Preview on hover no longer working
Replies
10
Views
418
chris p
C
Ozzy47
[OzzModz] Thread Linked Data Image Remove
Replies
2
Views
153
Ozzy47
Ozzy47
Ozzy47
[OzzModz] Remove Last Post Avatars
Replies
0
Views
104
Ozzy47
Ozzy47
Ozzy47
[OzzModz] Show Thread Title Above First Post
Replies
14
Views
360
Ozzy47
Ozzy47
Top Bottom