1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

As Designed They thought me to use {xen:link} :)

Discussion in 'Resolved Bug Reports' started by Vincent, Sep 21, 2011.

  1. Vincent

    Vincent Well-Known Member

    Hello,

    Some of the tips I received when creating add-ons was that I'd best use {xen:link} for linking.
    Today I found 2 links in the interface that don't use that :(

    The first one is in PAGE_CONTAINER
    Code:
    <a href="admin.php">{xen:phrase reopen_via_admin_control_panel}</a>
    to (I added this suggestion to it, so don't forget to mark as implented :D)

    Code:
    <a href="{xen:adminlink 'options/list/boardActive'}">{xen:phrase reopen_via_admin_control_panel}</a>
    The second one is in moderator_bar
    Code:
    <a href="admin.php" class="acp adminLink"><span class="itemLabel">{xen:phrase admin_control_panel}</span></a>
    to

    Code:
    <a href="{xen:adminlink}" class="acp adminLink"><span class="itemLabel">{xen:phrase admin_control_panel}</span></a>
     
  2. Kier

    Kier XenForo Developer Staff Member

    Fixed both.
     
    Vincent likes this.
  3. Kier

    Kier XenForo Developer Staff Member

    I've just reversed out these changes, as Mike pointed out to me that using {xen:adminlink ...} in front-end templates will cost one SQL query. Therefore, leave it as it is.
     
  4. Vincent

    Vincent Well-Known Member

    Oh right :)
    Well, noone is perfect :)

    Is the boardActive suggestion still implented?
     
  5. Kier

    Kier XenForo Developer Staff Member

    Yes it is :)
     
    Vincent likes this.

Share This Page