[TH] Custom Fields [Deleted]

[maxwolfie]

Hi Waindigo,

A few questions/notes after a few days of testing:

Major issues (for me)

1. BBCode does not seem to work in the custom fields.
2. Users cannot edit their posts to change what they put in the custom fields.

At the moment, those are two main "deal breaker" type issues that prevent me from doing what I need to do.


Minor issues (for me)

1. Cannot specify thread title with custom field entry.
2. Cannot replace user post with custom fields (still required to enter a post, and then fill out the fields).
3. When creating a new thread, the list of Custom Fields show in alphabetical order, even though I have my priorities set otherwise. You mentioned this is a bug previously.

If you could let me know if you have any plans to add/fix any of these, it would be greatly appreciated

 

[Jon W]

Hi Waindigo,

A few questions/notes after a few days of testing:

Major issues (for me)

1. BBCode does not seem to work in the custom fields.
2. Users cannot edit their posts to change what they put in the custom fields.

At the moment, those are two main "deal breaker" type issues that prevent me from doing what I need to do.

1. Are you referring to the header/footer? This is unlikely to be supported in the near future, but there is nothing you can do with BBCode that you can't do with HTML, and you can do even more with conditional statements etc.
If you are referring to the input to a custom field, then this is definitely something that I would like the add-on to support. Perhaps you would be willing to contribute to the development of this?
2. Yes they can, they need to edit the thread, not the post.

Minor issues (for me)

1. Cannot specify thread title with custom field entry.
2. Cannot replace user post with custom fields (still required to enter a post, and then fill out the fields).
3. When creating a new thread, the list of Custom Fields show in alphabetical order, even though I have my priorities set otherwise. You mentioned this is a bug previously.

If you could let me know if you have any plans to add/fix any of these, it would be greatly appreciated

1. Not sure how easy it would be to support this. Can you explain why you would want to do this?
2. I think this will be supported in the very near future.
3. Yes, this is a bug and will be fixed soon.

 

[ManOnDaMoon]

I found some bugs.

In ACP, Custom Fields list:
"Select All" not selecting anything.
EDIT : Applicable forums issue is not a bug, see below.

When creating a Library article (sorry if this is posted in the wrong thread):
The "Select Forum" field (from article_discussion_link custom field) does not list any of my forums. I am unable to link a thread to a new article.
EDIT : I figured this out : I need to select forums that will be selected here in the "Applicable forum" option of the field.

I'll be glad to help if you're having troubles replicating these. Thank you again for your work.

 

[ManOnDaMoon]

I'm back with another bug, this time easy to replicate:

The account/preferences page content encoding is messed up in non-english languages. This happens only when the Custom Fields addon is installed and enabled, all other addons disabled. It all reverts back to normal once Custom Fields disabled. See capture for example. Others preferences pages seem not to be subject to the issue, and even preferences navigation (left sidebar) is OK.

 

[Jon W]

I'm back with another bug, this time easy to replicate:

The account/preferences page content encoding is messed up in non-english languages. This happens only when the Custom Fields addon is installed and enabled, all other addons disabled. It all reverts back to normal once Custom Fields disabled. See capture for example. Others preferences pages seem not to be subject to the issue, and even preferences navigation (left sidebar) is OK.

I have spent the last 3 days trying to fix this bug and am losing a lot of money, despite the original contributor to this add-on not caring about non-English languages (hence it is not really a bug). I am on about my fifth attempt at fixing this. Fingers crossed!

 

[ManOnDaMoon]

I have spent the last 3 days trying to fix this bug and am losing a lot of money, despite the original contributor to this add-on not caring about non-English languages (hence it is not really a bug). I am on about my fifth attempt at fixing this. Fingers crossed!

This is a bug from Zend Framework.
I used the hack in this bug description : http://framework.zend.com/issues/browse/ZF-10788 and it worked for me.

Basically edit library/Zend/Dom/Query.php at line 257: replace

$success = $domDoc->loadHTML($document);

with

$success = $domDoc->loadHTML('<?xml encoding="'.$encoding.'">' .$document);

This may need an official bug report to the XF team.

 

[Jon W]

This is a bug from Zend Framework.
I used the hack in this bug description : http://framework.zend.com/issues/browse/ZF-10788 and it worked for me.

I tried this but had no luck. I've just created my own hack and it appears to work, so will be releasing shortly.

 

[ManOnDaMoon]

I tried this but had no luck. I've just created my own hack and it appears to work, so will be releasing shortly.

Curious that it worked for me. Maybe not trying a wild enough set of characters.

 

[Jon W]

Curious that it worked for me. Maybe not trying a wild enough set of characters.

Possibly not. I am working with some Vietnamese characters from www.tinhte.vn.

 

[ManOnDaMoon]

/me just sent a modest donation for your hard work trying to decipher Vietnamese.

 

[Jon W]

/me just sent a modest donation for your hard work trying to decipher Vietnamese.

Thanks. The solution is actually very simple. Can't believe it took me 4 days to come up with it!

 

[yavuz]

Thanks. The solution is actually very simple. Can't believe it took me 4 days to come up with it!

Jon, are you planning to update the copyright addon too? It has the same problem...

 

[Jon W]

Jon, are you planning to update the copyright addon too? It has the same problem...

Yes. All add-ons will be updated, although it is a shared file so you will only need to update one add-on that has this issue and all others will be fixed.

 

[Jon W]

Waindigo updated Custom Fields by Waindigo with a new update entry:

Version 1.0.3a released

Bug fixes:

• Fixed bug that custom fields appear in the wrong order.
• Fixed bug with non-English characters not appearing correctly.

Read the rest of this update entry...

 

[ManOnDaMoon]

The update did not resolve the encoding bug on my working copy. Didn't you forget one or two "_utf8Decode/Encode" (e.g. in Waindigo_CustomFields_Listener_TemplatePostRender::_accountFields() )?

 

[Jon W]

The update did not resolve the encoding bug on my working copy. Didn't you forget one or two "_utf8Decode/Encode" (e.g. in Waindigo_CustomFields_Listener_TemplatePostRender::_accountFields() )?

$this->_utf8Decode and $this->_utf8Encode are new custom-built functions that fix the encoding bug. Can you give an example of where this bug is not fixed?

 

[ManOnDaMoon]

$this->_utf8Decode and $this->_utf8Encode are new custom-built functions that fix the encoding bug. Can you give an example of where this bug is not fixed?

Exact same example as before in account/preferences/ .
View attachment 32265
Based on your update, I added calls to $this->_utf8Decode() at line 112 and $this->_utf8Encode() at line 136 of library/Waindigo/CustomFields/Listener/TemplatePostRender.php and it fixes it.

 

[Jon W]

Exact same example as before in account/preferences/ .
View attachment 32265
Based on your update, I added calls to $this->_utf8Decode() at line 112 and $this->_utf8Encode() at line 136 of library/Waindigo/CustomFields/Listener/TemplatePostRender.php and it fixes it.

Is this not already updated in the latest download of Custom Fields?

 

[ManOnDaMoon]

Is this not already updated in the latest download of Custom Fields?

Re-re-checked addon-Waindigo_CustomFields-1.0.3.1343685732.zip (current available version) and... nope.

 

[Jon W]

Re-re-checked addon-Waindigo_CustomFields-1.0.3.1343685732.zip (current available version) and... nope.

Just checked those line numbers. This bug should have been fixed a while ago, as it didn't need the most recent fix (for more exotic characters). Sorry about that.