Note System (NS2) [Deleted]

A new error now on the live site, which I believe is due to the whats new note addition, as I don't use thread notes and thus are not permission'd for staff.

Frontend error:

Code:
An exception occurred: [Error] Call to undefined method xenMade\STNS\XF\Entity\User::canViewUserOrThreadNotes() in src/addons/xenMade/STNS/FindNew/NoteItem.php on line 110
[LIST=1]
[*]xenMade\STNS\FindNew\NoteItem->isAvailable() in src/XF/ControllerPlugin/FindNew.php at line 88
[*]XF\ControllerPlugin\FindNew->getFindNewHandler() in src/XF/Pub/Controller/AbstractWhatsNewFindType.php at line 18
[*]XF\Pub\Controller\AbstractWhatsNewFindType->actionIndex() in src/XF/Mvc/Dispatcher.php at line 249
[*]XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
[*]XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
[*]XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1931
[*]XF\App->run() in src/XF.php at line 328
[*]XF::runApp() in index.php at line 13
[/LIST]
Backend Error:

Code:
Server error log
TypeError: Argument 1 passed to xenMade\STNS\Repository\Note::findNotesForThread() must be an instance of XF\Entity\Thread, null given, called in /home/nginx/domains/myptsd.com/public/src/addons/xenMade/STNS/XF/Pub/Controller/Thread.php on line 20 src/addons/xenMade/STNS/Repository/Note.php:11
Generated by: Unknown account Aug 12, 2018 at 7:29 PM
Stack trace
#0 src/addons/xenMade/STNS/XF/Pub/Controller/Thread.php(20): xenMade\STNS\Repository\Note->findNotesForThread(NULL)
#1 src/addons/Andy/SimilarThreads/XF/Pub/Controller/Thread.php(16): xenMade\STNS\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#2 src/addons/ForoAgency/PrivateMessageReplies/XF/Pub/Controller/Thread.php(11): Andy\SimilarThreads\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#3 src/addons/EWR/Porta/Pub/Controller/Thread.php(11): ForoAgency\PrivateMessageReplies\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#4 src/addons/Andy/History/XF/Pub/Controller/Thread.php(12): EWR\Porta\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#5 src/XF/Mvc/Dispatcher.php(249): Andy\History\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Thread', 'Index', 'html', Object(XF\Mvc\ParameterBag), 'forums', Object(Snog\Groups\XF\Pub\Controller\Thread), NULL)
#7 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#9 src/XF.php(328): XF\App->run()
#10 index.php(13): XF::runApp('XF\\Pub\\App')
#11 {main}
Request state
array(4) {
  ["url"] => string(109) "/threads/does-anyone-experience-blackouts-or-gapping-out-that-is-not-triggered-by-intoxication-or-rage.15548/"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["/threads/does-anyone-experience-blackouts-or-gapping-out-that-is-not-triggered-by-intoxication-or-rage_15548/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
 
Last edited:
NS2 is using the same URL structure for thread notes as @Xon Moderator Essentials do. There is a conflict which lead always to use Moderator Essentials thread notes.
 
NS2 is using the same URL structure for thread notes as @Xon Moderator Essentials do. There is a conflict which lead always to use Moderator Essentials thread notes.
and what am I supposed to do? Change my add-on?
It can happen, I'm sorry. But there is nothing I can do.
 
and what am I supposed to do? Change my add-on?
It can happen, I'm sorry. But there is nothing I can do.
This is your problem not mine. I thought that I should let you know about this but after all is your product and you can do whatever you want with it. I don't really care.

Uninstalled.
 
au lait updated Note System (NS2) with a new update entry:

2.0.0

This is a completely new version. This means, that after uploading this add-on 2 times is in the list. Click on "install" the new version. This will automatically remove the old version!
Do not uninstall the old version manually! This would lead to data loss of the Notes!


[info] Completely new code base and optimized
Therefore, many permissions are removed and others added
All styles have been changed

[add] Search for Notes possible
[fixed] What's news

Read the rest of this update entry...
 
Unless I've missed a permission somewhere, it appears that notes on new threads (What's New) are no longer visible with this newest version.
 
With 2.0.1 enabled clicking "Your Content" under user profiles results in this error:

An exception occurred: [Error] Call to undefined method xenMade\NS\Entity\NoteThread::canViewNoteUser() in src/addons/xenMade/NS/Search/Data/NoteThread.php on line 95

xenMade\NS\Search\Data\NoteThread->canViewContent() in src/XF/Search/Search.php at line 222
XF\Search\Search->XF\Search\{closure}()
array_filter() in src/XF/Mvc/Entity/AbstractCollection.php at line 167
XF\Mvc\Entity\AbstractCollection->filter() in src/XF/Search/Search.php at line 223
XF\Search\Search->getResultSetData() in src/XF/ResultSet.php at line 228
XF\ResultSet->loadResultsData() in src/XF/ResultSet.php at line 212
XF\ResultSet->limitToViewableResults() in src/XF/ResultSet.php at line 181
XF\ResultSet->sliceResults() in src/XF/ResultSet.php at line 191
XF\ResultSet->limitResults() in src/XF/Search/Search.php at line 166
XF\Search\Search->search() in src/XF/Repository/Search.php at line 34
XF\Repository\Search->runSearch() in src/XF/Pub/Controller/Search.php at line 388
XF\Pub\Controller\Search->runSearch() in src/XF/Pub/Controller/Search.php at line 240
XF\Pub\Controller\Search->actionMember() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1931
XF\App->run() in src/XF.php at line 329
XF::runApp() in index.php at line 13

Not sure if this also happened under 2.0 and I just didn't notice it before....
 
With 2.0.1 enabled clicking "Your Content" under user profiles results in this error:

An exception occurred: [Error] Call to undefined method xenMade\NS\Entity\NoteThread::canViewNoteUser() in src/addons/xenMade/NS/Search/Data/NoteThread.php on line 95

Not sure if this also happened under 2.0 and I just didn't notice it before....
sorry! Fixed in the next version!
 
Top Bottom