1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

[KL] Password Tools 2.0.0

Cause safer passwords are better passwords.

  1. katsulynx

    katsulynx Well-Known Member

    katsulynx submitted a new resource:

    [KL] Password Tools - Cause safer passwords are better passwords.

    Read more about this resource...
     
    BobbyWibowo, Xon and rafass like this.
  2. Xon

    Xon Well-Known Member

    What licence does this have? (ie using the XF resource manager licencing field)
     
  3. rafass

    rafass Well-Known Member

    Thanks for this great addon katsulynx
    I'll test in 1.5.0RC2
     
    katsulynx likes this.
  4. katsulynx

    katsulynx Well-Known Member

    MIT Licence, updated said field. The Licence for Zxcvbn is included in the download.
     
    Xon likes this.
  5. rafass

    rafass Well-Known Member

  6. katsulynx

    katsulynx Well-Known Member

    Woopsie, forgot to include the screenshots :D
     
    Xon likes this.
  7. Xon

    Xon Well-Known Member

    Code:
        public static function extend($class, array &$extend) {
            if (!class_exists('XFCP_KL_PasswordTools_DataWriter_User', false)) {
                $extend[] = 'KL_PasswordTools_DataWriter_User';
            }
        }
    
    No point adding the class_exist checks, you can just append to $extend blindly. (You can add a version check in for < XF1.2 so you can always ensure the hint is respected)
     
    rafass and katsulynx like this.
  8. Xon

    Xon Well-Known Member

    Your addon looks fairly straight forward and well put together.

    A few other bits:
    1. Should respect the "$requirePassword". When migrating between authentication providers, the requirePassword is false and permits and empty password to be stored.
    2. IMO, the large json should be converted into php arrays, this will then allow opcode caching to handle those files rather than causing ~3mb of IO every time someone sets a password.
     
  9. katsulynx

    katsulynx Well-Known Member

    rafass and Xon like this.
  10. Xon

    Xon Well-Known Member

    Small template mod tweak, You have the following repeated twice:
    Code:
    <xen:require js="js/KL/PasswordTools/zxcvbn-async.js" />
    <xen:require js="js/KL/PasswordTools/PasswordStrengthMeter.js" />
    <xen:include template="KL_PasswordStrengthMeter_Setup" />
    
    Any reason those javascript include aren't be pushed into the KL_PasswordStrengthMeter_Setup template to make the template modifications simpler?


    The default text strength colour on a dark theme are fairly unreadable:
    dark_theme.png
     
    Last edited: Aug 15, 2015
    rafass likes this.
  11. katsulynx

    katsulynx Well-Known Member

    I've actually tried that, but it didn't work for a reason I wasn't able to identify.

    You can change that in the Style Properties. 'Segments' holds the default color for the bars, 'Phrase' the one for the phrase.
     
  12. BobbyWibowo

    BobbyWibowo Well-Known Member

    This is being applied to the ones on registration page and password change, correct?
     
  13. katsulynx

    katsulynx Well-Known Member

    Exactly.
     
    BobbyWibowo likes this.
  14. Xon

    Xon Well-Known Member

    Weird.

    Could you set the 'Phrase' default foreground color to something like @textCtrlText rather than an an explicit hardcoded color? This will then work properly across most themes without modification.
     
    rafass and Steve F like this.
  15. rafass

    rafass Well-Known Member

    In 1.5.0RC2 is not working.
    I've seen that require FA. in my case I don't have and I don't want to use FA,
    would be great make this optional, if possible.
     
  16. katsulynx

    katsulynx Well-Known Member

    It is optional.
     
  17. katsulynx

    katsulynx Well-Known Member

    Changed to @mutedTextColor for the next version.

    Double-checked that, couldn't find anything not working though. What exactly is not working for you?
     
    Xon likes this.
  18. BobbyWibowo

    BobbyWibowo Well-Known Member

    Screenshot (297).png
    Am I doing something wrong? Getting this error on registration (after filling details then sign up). I'm on XenForo 1.4.10.
     
    Last edited: Aug 18, 2015
    katsulynx likes this.
  19. rafass

    rafass Well-Known Member

    editing with more info...
     
  20. BobbyWibowo

    BobbyWibowo Well-Known Member

    Still waiting for stable 1.5, lol
     
    rafass likes this.

Share This Page