Fixed Draft save race condition

Mike

Mike

XenForo developer
Staff member
Looks like there's a potential situation where the draft save can fire off while the form is being submitted.
 
Mike said:
Looks like there's a potential situation where the draft save can fire off while the form is being submitted.
Click to expand...
Does the system notify the user that it's saved the draft? I tried in test mesages forum but did not get any notification.
 
TheBigK said:
Does the system notify the user that it's saved the draft? I tried in test mesages forum but did not get any notification.
Click to expand...
It is automatically saved. Write something, try to navigate away then come back, you would see your text is still there.
 
I think this only applies to 1.2 unless I stand corrected. (unless you are talking about an update to the beta you are testing currently)
 
Clickfinity said:
TBH I was sure it was an ACP on/off option, but re-reading the HYS thread I can't see that it is.

@Mike - can we enable/disable the draft saving feature?
Click to expand...

Can the draft feature be disabled? I'm trying to debug why we get editor lag on some devices and wanted to check it wasn't due to the draft stuff.
 
RobParker said:
Can the draft feature be disabled? I'm trying to debug why we get editor lag on some devices and wanted to check it wasn't due to the draft stuff.
Click to expand...
No, it's basically due to JS and it happens mostly on "weak" cellphones. The only solution for that is to tell people to use the simple editor.
 
Moshe1010 said:
No, it's basically due to JS and it happens mostly on "weak" cellphones. The only solution for that is to tell people to use the simple editor.
Click to expand...

What makes you say that?

We're seeing lag with the iphone 5 and ipad 3 as well as new samsung phones. It's not consistent among devices (my iphone is fine but I do see it on my ipad).
 
RobParker said:
What makes you say that?

We're seeing lag with the iphone 5 and ipad 3 as well as new samsung phones. It's not consistent among devices (my iphone is fine but I do see it on my ipad).
Click to expand...
It is consistent with Samsung S2/3/HTC One and some other more. It depends mostly on the device itself (Hardware), and software (many custom roots are just terrible). I have an iPhone 5 and I have no issues with the editor. iPad 2 has slight lag when typing fast; I can't confirm iPad 3...
 
Moshe1010 said:
It is consistent with Samsung S2/3/HTC One and some other more. It depends mostly on the device itself (Hardware), and software (many custom roots are just terrible). I have an iPhone 5 and I have no issues with the editor. iPad 2 has slight lag when typing fast; I can't confirm iPad 3...
Click to expand...

My point is it's not that simple. My iPad 3 is laggy, others have been fine. Equally my iPhone 5 is perfectly fine but we've had lots of other users complain about their iPhone 5 experiencing lag. The guys at PixelExit haven't been able to duplicate any lag but for me it happens on both our site and theirs pretty consistently with my iPad.
 

Similar threads

X
Unphrased date-time due to race condition in front-end javascript
Replies
0
Views
167
Xon
X
K
User not upgraded after purchasing a subscription with stripe ( Race condition )
Replies
3
Views
830
nates
N
X
Fixed Race condition in XF\Util\File::createTempDir
Replies
4
Views
902
XF Bug Bot
XF Bug Bot
TickTackk
Fixed Race condition in markUserAlertUnread and markUserAlertRead
Replies
2
Views
751
Jeremy P
Jeremy P
X
Won't fix Race conditional allows warnings to be issued to content twice
Replies
7
Views
702
PaulB
PaulB
Back
Top Bottom