Defer JS [Deleted]

[Kerby]

When I go to ACP Maintenance and start "File Health Check" I see a white page and in Error Log following new entry:

ErrorException: Fatal Error: syntax error, unexpected '[' - library/Jrahmy/DeferJs/FileSums.php:28

#0 [internal function]: XenForo_Application::handleFatalError()
#1 {main}

array(3) {
["url"] => string(45) ".../admin.php?tools/file-check"
["_GET"] => array(1) {
["tools/file-check"] => string(0) ""
}
["_POST"] => array(1) {
["_xfToken"] => string(8) "********"
}
}

After disabling DeferJS, it's working without error log entry. After enabling DeferJS again, error is there again.

 

[Jeremy P]

@Kartus

Bleh. That's what I get for making build tools that don't support PHP 5.3.

Just updated the PHP 5.3 version, should fix this. Reimporting XML is not necessary, just upload the files.

Thanks for reporting.

 

[rdn]

Still works even if I have ngx_pagespeed enabled?

 

[Jeremy P]

@RoldanLT, Should be fine, though I think pagespeed might perform this optimization itself, in which case the addon is redundant.

If pagespeed doesn't do this then they should work fine together.

 

[rdn]

I have disabled pagespeed defer feature.
Sometimes adsense doesn't load on first time visit, and causing my revenue to drop.

 

[rdn]

Looks like this addon, also applied to admin page?

 

[Brent W]

Per @RoldanLT this add-on breaks certain areas of the admin.php, especially editing the page_container tempate:



This add-on should ignore any admin area pages.

 

[Jeremy P]

I have disabled pagespeed defer feature.
Sometimes adsense doesn't load on first time visit, and causing my revenue to drop.

Make sure the addon is correctly configured to skip deferring of adsense scripts.

Per @RoldanLT this add-on breaks certain areas of the admin.php, especially editing the page_container tempate:

View attachment 74667

This add-on should ignore any admin area pages.

Have you found other broken areas or just page_container?

I will push an update in the next couple of days to fix this.

 

[Jeremy P]

Jeremy P updated Defer JS with a new update entry:

Disabled AdminCP Deferring

The Admin Control Panel doesn't always behave correctly when scripts are deferred, so this release stops deferring pages in the ACP.

The PHP 5.3 build has been updated, which is available in the FAQ.

Enjoy!

Read the rest of this update entry...

 

[rdn]

Does my Blacklist Filter already duplicate?

 

[Jeremy P]

It's a bit redundant but it won't hurt

 

[rdn]

Cause your default filter are just google_ad and show_ad, don't have s

 

[Jeremy P]

Cause your default filter are just google_ad and show_ad, don't have s

That'll still filter them though but nice catch, I suppose I'll adjust that in the development version.

 

[AzzidReign]

Had to disable this because when we enabled the Google Ajax API CDN, it broke the site :/

 

[rdn]

Had to disable this because when we enabled the Google Ajax API CDN, it broke the site :/

Why not just add it to the filter list?

 

[AzzidReign]

Why not just add it to the filter list?

What would you add?

We already added almost everything to the list because it was breaking the site

 

[rdn]

The whole domain: ajax.googleapis.com or the filename of the js.
But as I can see right now, you're using ngx_pagespeed right?

 

[AzzidReign]

The whole domain: ajax.googleapis.com or the filename of the js.
But as I can see right now, you're using ngx_pagespeed right?

Was messing around with it to see how the scores worked. But with my set up...we had to install it on our proxy server and it was causing too many issues with gzip and adding too much overhead that we are now disabling it :/ I'm just trying to improve my scores and every turn I take leads me to "you broke the site/server".

 

[AzzidReign]

This is what I've had to disable (which is basically everything):

adsbygoogle
google_ad
show_ad
response.min
response
xenforo
jquery-1.11.0.min
advertisement
if (document.getElementById("tester") != undefined)
ajax.googleapis.com

 

[rdn]

Was messing around with it to see how the scores worked. But with my set up...we had to install it on our proxy server and it was causing too many issues with gzip and adding too much overhead that we are now disabling it :/ I'm just trying to improve my scores and every turn I take leads me to "you broke the site/server".

@eva2000 has working config here: https://community.centminmod.com/threads/this-forums-pagespeed-conf.62/
Specifically for XenForo, tested many times with ads also.