Fixed Bug in library\XenForo\Model\DataRegistry.php

[Yoskaldyr]

I've tried to use file-cache and after enabling it in the config.php I've found a problem - forum script recreates cache after every request. So I went to look where the problem is, and (surprise, surprise =)) I've found it in the XenForo_Model_DataRegistry class in the method getMulti - there is a unset function call, which should delete an array item, but there is wrong key used to do this. So there is a quickfix:
find

        $cache = $this->_getCache(true);
        $dbItemNames = $itemNames;
        $data = array();

        foreach ($itemNames AS $itemName)
        {
            $cacheData = ($cache ? $cache->load($this->_getCacheEntryName($itemName)) : false);
            if ($cacheData !== false)
            {
                $data[$itemName] = $cacheData;
                unset($dbItemNames[$itemName]);
            }
        }

Replace with

        $cache = $this->_getCache(true);
        $dbItemNames = array();
        $data = array();

        foreach ($itemNames AS $itemName)
        {
            $cacheData = ($cache ? $cache->load($this->_getCacheEntryName($itemName)) : false);
            if ($cacheData !== false)
            {
                $data[$itemName] = $cacheData;
            }
            else
            {
                 $dbItemNames[] = $itemName;
            }
        }

 

[Yoskaldyr]

Bug is still present in the beta 3

 

[Mike]

Changed the code differently (the unset should be based on the key, not the value), but fixed now. Thanks