Search results

  1. Kier

    Pluralization

    That said, I like the principle of the Laravel scheme, perhaps we could come up with something that also hits the other requirements.
  2. Kier

    Pluralization

    The Laravel approach is nice, but it doesn't actually solve the problem as far as I can see, as it doesn't (appear) to allow rules that apply (for example) to all numbers that end in the digit 2 (2, 12, 22, 32... n2) with a separate rule for all numbers that end in 3 (3, 13, 23... n3) and other...
  3. Kier

    Fixed Brand fa icon in bb code manager

    Looks like we hard-code the fa- in \XF\Data\Editor->getCustomBbCodeButtons() so now I have to work out why it works on the front end at all...
  4. Kier

    Fixed Timestamp issues after timezone changes

    @Steffen it seems to me that for those day-of-week values, we are dealing with an absolute value rather than a relative one, so we should be able to just use the system back-end to get the DoW from the timestamp, with appropriate adjustments (done largely automatically if we stay within the XF...
  5. Kier

    Fixed Console fails to render Errors, expects Exceptions (php7.3)

    Can you provide a code snippet to reproduce? I'm testing with PHP 7.3.7 and not seeing an error so far. I presume the error is coming from the catch with \Throwable $e in it?
  6. Kier

    Fixed New reply notifications can be missing as a result of merging threads/posts

    Might have a reasonable solution - to be called after updateUserCounters() in the thread merger: protected function updateThreadReadData() { $sourceThreadIds = $this->db()->quote(array_keys($this->sourceThreads)); $this->db()->query(" UPDATE xf_thread_read AS...
  7. Kier

    Fixed New reply notifications can be missing as a result of merging threads/posts

    ... of course that only handles one thread being merged into another - I forgot that you can merge multiple!
  8. Kier

    Fixed New reply notifications can be missing as a result of merging threads/posts

    I'm just wondering if we could do something along the lines of UPDATE xf_thread_read AS dst LEFT JOIN xf_thread_read AS src ON (dst.user_id = src.user_id AND src.thread_id = ?) SET dst.thread_read_date = LEAST(dst.thread_read_date, src.thread_read_date) WHERE dst.thread_id = ?;Passing in the...
  9. Kier

    Fixed Race conditional when unignoring can cause unexpected error

    This was fixed alongside this one
  10. Kier

    Fixed Invisible ReCaptcha on Login

    Update on this - I've just reimagined the fix, and there is no longer a BC break.
  11. Kier

    Fixed Thread/Post drafts cause multiple html => bbcode conversion

    Given that the call to save the draft and the call to show the preview are separate HTTP requests that would share no state or data, short of creating some sort of stateless cache like writing the result of fromInput() into memcache or something similar, this seems like it's just one of those...
  12. Kier

    Future fix Mention autocomplete doesn't work in some cases where the username contains an '@' character

    FWIW, this was the code behind that, replacing everything from var lastAt = text.lastIndexOf(this.options.at); up until the final return null; var m = text.match(new RegExp('(^|\\s|[\\](,]|--)' + this.options.at + '([^,\\n]{1,14})$')); if (m) {...
  13. Kier

    Future fix Mention autocomplete doesn't work in some cases where the username contains an '@' character

    I've looked into this and I think it might be unfixable without introducing new flaws. I tried to approach the problem by ditching the lastAt principle and instead looking for a username-type regex match at the end of the text selection, but see for yourself the problems that can cause:
  14. Kier

    Not a bug Template 'message_macros' Not Respecting Value display HTML

    Can I just confirm that you are editing the message_macros template in order to add your ppMeLink code? If so, that's really not how the system is supposed to work - you shouldn't need to edit the template, you should simply enable the 'Custom Fields' option in the messages style properties...
  15. Kier

    As designed CLI add-on uninstall confirmation defaults to Yes

    Having looked into this, we've decided to retain it as the intended behaviour, primarily because of the implications for unattended, scripted interaction. Having the command default to 'no' would break this, in its current state.
  16. Kier

    XenForo Redirects for vBulletin

    I’ll do some more testing with nginx.
  17. Kier

    XF 2.1 REGEX Username Validation

    /^[a-z0-9]+$/i is correct and will match letters and numbers only, excluding spaces, as required in the original post.
  18. Kier

    Won't fix updateResultsToJson does not batch update

    The potential for multi-part primary keys makes this challenging with the currently-abstracted code - and as this is a once-only operation, I'm not sure it really warrants development attention for the small proportion of sites that will be running separate php and db servers.
  19. Kier

    Awaiting feedback Emoji Issue

    I don't think I'm able to reproduce this, though I'm a little confused by your description of events, specifically when it comes to the 'and then press the enter key' part. The following was recorded with Firefox 68. In it, I open the smilie/emoji menu and click some icons then watch them...
Top